Change in coreboot[master]: mb/google/brya/var/redrix: Correct WWAN power sequence - coreboot-gerrit

12 Nov 2021


      Attention is currently required from: Chen Wisley.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59267 )
Change subject: mb/google/brya/var/redrix: Correct WWAN power sequence
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/redrix/gpio.c:
https://review.coreboot.org/c/coreboot/+/59267/comment/41447a61_588145ac 
PS2, Line 71: 	/* E0 : SATAXPCIE0 ==> WWAN_PERST_L */
suggestion: add a comment here explaining that E0 is sequenced out-of-order here is so that PERST_L is sequenced after RST_L
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59267
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibba1ecc04b563ae4eedd7596594f33812cbac150
Gerrit-Change-Number: 59267
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Chen Wisley wisley.chen@quantatw.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 21:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment