Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44624 )
Change subject: util/abuild: Delete temporary config in failure case ......................................................................
util/abuild: Delete temporary config in failure case
Change-Id: I9b6e6b6dcfbf2b1f43c98027acae8d9af61bd6d8 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/abuild/abuild 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44624/1
diff --git a/util/abuild/abuild b/util/abuild/abuild index f90e2b3..c94b6b9 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -852,6 +852,7 @@ junit "</failure>" junit "</testcase>" echo "Shared Utilities - Log: $TARGET/sharedutils/make.log" >> "$FAILED_BOARDS" + rm "$TMPCFG" return fi
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44624 )
Change subject: util/abuild: Delete temporary config in failure case ......................................................................
Patch Set 2: Code-Review+1
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44624 )
Change subject: util/abuild: Delete temporary config in failure case ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44624 )
Change subject: util/abuild: Delete temporary config in failure case ......................................................................
util/abuild: Delete temporary config in failure case
Change-Id: I9b6e6b6dcfbf2b1f43c98027acae8d9af61bd6d8 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44624 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/abuild/abuild 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/util/abuild/abuild b/util/abuild/abuild index f90e2b3..c94b6b9 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -852,6 +852,7 @@ junit "</failure>" junit "</testcase>" echo "Shared Utilities - Log: $TARGET/sharedutils/make.log" >> "$FAILED_BOARDS" + rm "$TMPCFG" return fi
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44624 )
Change subject: util/abuild: Delete temporary config in failure case ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16259 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16258 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16257 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16256 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16255 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : FAIL : https://lava.9esec.io/r/16261 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16260
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)