Attention is currently required from: Nico Huber, Tarun Tuli, Subrata Banik, Rizwan Qureshi, Lean Sheng Tan.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74376 )
Change subject: [RFC]soc/intel/cannonlake: Use regular NEM for CAR
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
we shoudn't blindly check NEM over eNEM
Do you know a way at runtime to figure this out? I'm thinking SDM is either wrong or silicon has problem with cpuid being wrong.
PS1:
seems like MSR IA32_PQR_ASSOC still exists? or could be wrong?
So not sure which MSR used in NEM_ENHANCED is actually resulting in a hang, but the bits in cpuid are clearly not working as indicator for their presence as they do work on some models where the cpuid bits are 0.
PS1:
Maybe there's something else we could use to filter the working CPUs, e.g.
stepping ID?
Saddly not. same stepping, but different CPU branded model have different results.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74376
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I141cf1543eb59bce86528012a6549101d5911865
Gerrit-Change-Number: 74376
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 12:55:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment