Attention is currently required from: Angel Pons, Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Nicholas Chin, Nico Huber, Sean Rhodes.
Jean Lucas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
Change subject: payloads/edk2: Add Kconfig to use LAPIC timer
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82000/comment/f6862291_991d8716 :
PS3, Line 7: paylods
Spelling: payloads
Done
Patchset:
PS1:
needs to pass the coreboot Kconfig to the edk2 makefile, see CB:81892
Done
File payloads/external/edk2/Kconfig:
https://review.coreboot.org/c/coreboot/+/82000/comment/c1f4feae_2d17ae70 :
PS1, Line 315: Select this option to use the LAPIC timer driver instead of HPET. It is needed for GM45
: platforms which have issues with the HPET on Intel Core 2 Duo.
nit: reflow these lines to have about the same length: […]
Done
File src/northbridge/intel/gm45/Kconfig:
https://review.coreboot.org/c/coreboot/+/82000/comment/948fa11c_e5cdab8f :
PS3, Line 52: config EDK2_USE_LAPIC_TIMER
+1, as these CPUs are also used with the i945 and x4x northbridges. […]
Added to x4x and i945 northbridge Kconfigs for now. Holding off on model_106cx.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 5
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Fri, 19 Apr 2024 15:41:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment