Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jonathon Hall, Lance Zhao.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78095?usp=email )
Change subject: acpi/acpigen_ps2_keybd: Reduce minimum keys, optional alpha/num/punct
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
A keymap was necessary so osk-sdl doesn't think the PS/2 keyboard is a "full keyboard" - it shows th […]
ack
File src/include/acpi/acpigen_ps2_keybd.h:
https://review.coreboot.org/c/coreboot/+/78095/comment/bf89906e_28b7a16d :
PS2, Line 39: has_alpha_num_punct_keys
Personally I like `has_alpha_num_punct_keys` because it is more precise, the meaning of "full keyboa […]
nah, works for me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78095?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf80b184ec816043138750ee0a869b23f1e6dcf2
Gerrit-Change-Number: 78095
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Thu, 28 Sep 2023 13:14:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-MessageType: comment