Attention is currently required from: Yuchen He.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75959?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/cannonlake/chip.h: Use boolean type where applicable
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/75959/comment/43ee00bc_a1b13225 :
PS2, Line 444: bool cpu_ratio_override;
This says the range is 0-63, should this stay uint8_t?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75959?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9639bd1d0737f94931c28b0e12f214a5c1f87c0
Gerrit-Change-Number: 75959
Gerrit-PatchSet: 2
Gerrit-Owner: Yuchen He
yuchenhe126@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Yuchen He
yuchenhe126@gmail.com
Gerrit-Comment-Date: Wed, 21 Jun 2023 18:03:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment