Attention is currently required from: Tim Wawrzynczak, Curtis Chen, Patrick Rudolph.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59644 )
Change subject: soc/intel/alderlake: Add TDP to give correct VR configuration.
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/59644/comment/28224760_138a4fdc
PS1, Line 42: 34250
line up with the others, please
Is this just gerrit?
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/59644/comment/5315a266_b36f65e4
PS1, Line 111: u8
ditto
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59644
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d31e7afc76d9a8c772781671f92ec08f9d8713f
Gerrit-Change-Number: 59644
Gerrit-PatchSet: 1
Gerrit-Owner: Curtis Chen
curtis.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Curtis Chen
curtis.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 30 Nov 2021 00:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment