Change in coreboot[master]: mb/google/glados/var/sentry: Relocate devicetree FSP settings

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43885 )

Change subject: mb/google/glados/var/sentry: Relocate devicetree FSP settings
......................................................................

mb/google/glados/var/sentry: Relocate devicetree FSP settings

Tested with BUILD_TIMELESS=1, its coreboot.rom does not change.

Change-Id: I4d3df3070d22f2d47214d044d197d31d9c4ef7ea
Signed-off-by: Angel Pons 
---
M src/mainboard/google/glados/variants/sentry/overridetree.cb
1 file changed, 7 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/43885/1

diff --git a/src/mainboard/google/glados/variants/sentry/overridetree.cb b/src/mainboard/google/glados/variants/sentry/overridetree.cb
index 08d3dd3..569234b 100644
--- a/src/mainboard/google/glados/variants/sentry/overridetree.cb
+++ b/src/mainboard/google/glados/variants/sentry/overridetree.cb
@@ -1,7 +1,5 @@
 chip soc/intel/skylake

-	register "ScsSdCardEnabled" = "2"
-
    register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)"	# Type-C Port 1
    register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC1)"	# Type-C Port 2
    register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)"	# Bluetooth
@@ -14,14 +12,9 @@
    register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC2)" # Type-A Port (card)
    register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC3)" # Type-A Port (board)

-	# I2C0 is 3.3V
-	register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3"
-
-	# Use default SD card detect GPIO configuration
-	register "sdcard_cd_gpio_default" = "GPP_A7"
-
    device domain 0 on
    	device pci 15.0 on
+			register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3"
    		chip drivers/i2c/generic
    			register "hid" = ""RAYD0001""
    			register "desc" = ""Raydium Touchscreen""
@@ -76,7 +69,12 @@
    			device i2c 35 on end
    		end
    	end # I2C #4
-		device pci 1e.6 on  end # SDCard
+		device pci 1e.6 on      # SDCard
+			register "ScsSdCardEnabled" = "2"
+
+			# Use default SD card detect GPIO configuration
+			register "sdcard_cd_gpio_default" = "GPP_A7"
+		end
    	device pci 1f.3 on
    		chip drivers/generic/max98357a
    			register "hid" = ""MX98357A""

Change in coreboot[master]: mb/google/glados/var/sentry: Relocate devicetree settings

[Angel Pons (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43885

to look at the new patch set (#2).

Change subject: mb/google/glados/var/sentry: Relocate devicetree settings
......................................................................

mb/google/glados/var/sentry: Relocate devicetree settings

Tested with BUILD_TIMELESS=1, its coreboot.rom does not change.

Change-Id: I4d3df3070d22f2d47214d044d197d31d9c4ef7ea
Signed-off-by: Angel Pons 
---
M src/mainboard/google/glados/variants/sentry/overridetree.cb
1 file changed, 7 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/43885/2

Change in coreboot[master]: mb/google/glados/var/sentry: Relocate devicetree settings

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43885 )

Change subject: mb/google/glados/var/sentry: Relocate devicetree settings
......................................................................

Abandoned