[L] Change in coreboot[master]: drivers/ipmi/ocp: add PCIe SEL support - coreboot-gerrit

3 Nov 2022


      Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, Rocky Phagura, Paul Menzel, Shuming Chu (Shuming), Tim Chu.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68758 )
Change subject: drivers/ipmi/ocp: add PCIe SEL support
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/drivers/ipmi/ocp/ipmi_sel.c:
https://review.coreboot.org/c/coreboot/+/68758/comment/e59900ff_79c38da1 
PS7, Line 11: 	if (CONFIG(IPMI_KCS))
Why?
ipmi_add_sel_entry is only called in ipmi_send_to_bmc and that is already guarded by if(CONFIG(IPMI_KCS)) - there should be no need to guard it twice.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68758
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ee46c8da7dbccbe1e2cc00bfe62e5df2f072d65
Gerrit-Change-Number: 68758
Gerrit-PatchSet: 7
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Rocky Phagura rphagura@fb.com
Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Shuming Chu (Shuming) s1218944@gmail.com
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Jonathan Zhang jonzhang@fb.com
Gerrit-Attention: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Attention: Rocky Phagura rphagura@fb.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shuming Chu (Shuming) s1218944@gmail.com
Gerrit-Attention: Tim Chu Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 22:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment