Attention is currently required from: Arthur Heymans, Elyes Haouas, Felix Held, Julius Werner.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84059?usp=email )
Change subject: drivers/spi: Stop using a variable-length array ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84059/comment/8e799788_a8dfec2a?usp... : PS2, Line 7: drivers/spi: Stop using a variable-length array I'd add a `, 2nd try` suffix to help differentiate between the original and reverted commit.
https://review.coreboot.org/c/coreboot/+/84059/comment/18930118_0cf01315?usp... : PS2, Line 22: in nit: if you move `in` to the next line, this paragraph would have the same line length as the other two
https://review.coreboot.org/c/coreboot/+/84059/comment/43e1a058_3b9360e5?usp... : PS2, Line 27: https://review.coreboot.org/c/coreboot/+/50480 I'd reference the commit hash instead