Attention is currently required from: Shelley Chen, Ravi kumar, Sudheer Amrabadi, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 )
Change subject: HACK sc7280: QSIP SPI NOR addressing mode for SKU1 and SKU2 HACK ......................................................................
Patch Set 102:
(4 comments)
File src/drivers/spi/spi_flash.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137372): https://review.coreboot.org/c/coreboot/+/50586/comment/7f4d60ce_ee29983b PS102, Line 533: while (1) suspect code indent for conditional statements (24, 24)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137372): https://review.coreboot.org/c/coreboot/+/50586/comment/74595a33_a7a53588 PS102, Line 554: while (1) suspect code indent for conditional statements (24, 24)
File src/soc/qualcomm/common/qclib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137372): https://review.coreboot.org/c/coreboot/+/50586/comment/95c2adae_4e676aea PS102, Line 254: mainboard_blob_fix(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137372): https://review.coreboot.org/c/coreboot/+/50586/comment/4ad11f1b_15c69e8c PS102, Line 254: mainboard_blob_fix(); please, no spaces at the start of a line