Attention is currently required from: Angel Pons, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Nico Huber, Shelley Chen, Tarun Tuli, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67490?usp=email )
Change subject: gma: Update DP training with new fields
......................................................................
Patch Set 23:
(1 comment)
File common/ironlake/hw-gfx-gma-pch-dp.ads:
https://review.coreboot.org/c/libgfxinit/+/67490/comment/de934c97_7626afc0 :
PS19, Line 26: Reason => "Needed for a common interface"
@arthur@aheymans.xyz could you please share your thoughts on the above comment?
You define a variable in template and based on that one you call the function with the right signature.
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/67490?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I3f7f8a93408a74cfa29d1493a48c88ce73dc690c
Gerrit-Change-Number: 67490
Gerrit-PatchSet: 23
Gerrit-Owner: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 23 Feb 2024 08:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment