Change in coreboot[master]: nvidia/tegra210: Enable RETURN_FROM_VERSTAGE to free up space
Hello Aaron Durbin,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/36800
to review the following change.
Change subject: nvidia/tegra210: Enable RETURN_FROM_VERSTAGE to free up space ......................................................................
nvidia/tegra210: Enable RETURN_FROM_VERSTAGE to free up space
All stages on this board are very close to the limit, so enable RETURN_FROM_VERSTAGE so that we can overlap verstage and romstage to use the available SRAM more effectively. (Coincidentally, this also reduces verstage size quite a bit... maybe we should consider just making this the default at some point, there are really no downsides.)
Change-Id: I2b91fd13d147f964bcbd7b2850f8a0931ea060df Signed-off-by: Julius Werner jwerner@chromium.org --- M src/soc/nvidia/tegra210/Kconfig M src/soc/nvidia/tegra210/include/soc/memlayout.ld 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/36800/1
diff --git a/src/soc/nvidia/tegra210/Kconfig b/src/soc/nvidia/tegra210/Kconfig index 0e1efd7..780fa18 100644 --- a/src/soc/nvidia/tegra210/Kconfig +++ b/src/soc/nvidia/tegra210/Kconfig @@ -16,6 +16,7 @@ config VBOOT select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_SEPARATE_VERSTAGE + select VBOOT_RETURN_FROM_VERSTAGE select VBOOT_MUST_REQUEST_DISPLAY
config MAINBOARD_DO_DSI_INIT diff --git a/src/soc/nvidia/tegra210/include/soc/memlayout.ld b/src/soc/nvidia/tegra210/include/soc/memlayout.ld index 6d74ab9..1134da6 100644 --- a/src/soc/nvidia/tegra210/include/soc/memlayout.ld +++ b/src/soc/nvidia/tegra210/include/soc/memlayout.ld @@ -38,9 +38,8 @@ STACK(0x4000C400, 3K) #endif TIMESTAMP(0x4000D000, 2K) - BOOTBLOCK(0x4000D800, 30K) - VERSTAGE(0x40015000, 68k) - ROMSTAGE(0x40026000, 104K) + BOOTBLOCK(0x4000D800, 42K) + OVERLAP_VERSTAGE_ROMSTAGE(0x40018000, 160K) SRAM_END(0x40040000)
DRAM_START(0x80000000)
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36800 )
Change subject: nvidia/tegra210: Enable RETURN_FROM_VERSTAGE to free up space ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36800 )
Change subject: nvidia/tegra210: Enable RETURN_FROM_VERSTAGE to free up space ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36800 )
Change subject: nvidia/tegra210: Enable RETURN_FROM_VERSTAGE to free up space ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36800 )
Change subject: nvidia/tegra210: Enable RETURN_FROM_VERSTAGE to free up space ......................................................................
nvidia/tegra210: Enable RETURN_FROM_VERSTAGE to free up space
All stages on this board are very close to the limit, so enable RETURN_FROM_VERSTAGE so that we can overlap verstage and romstage to use the available SRAM more effectively. (Coincidentally, this also reduces verstage size quite a bit... maybe we should consider just making this the default at some point, there are really no downsides.)
Change-Id: I2b91fd13d147f964bcbd7b2850f8a0931ea060df Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36800 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/soc/nvidia/tegra210/Kconfig M src/soc/nvidia/tegra210/include/soc/memlayout.ld 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Aaron Durbin: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/nvidia/tegra210/Kconfig b/src/soc/nvidia/tegra210/Kconfig index 0e1efd7..780fa18 100644 --- a/src/soc/nvidia/tegra210/Kconfig +++ b/src/soc/nvidia/tegra210/Kconfig @@ -16,6 +16,7 @@ config VBOOT select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_SEPARATE_VERSTAGE + select VBOOT_RETURN_FROM_VERSTAGE select VBOOT_MUST_REQUEST_DISPLAY
config MAINBOARD_DO_DSI_INIT diff --git a/src/soc/nvidia/tegra210/include/soc/memlayout.ld b/src/soc/nvidia/tegra210/include/soc/memlayout.ld index 6d74ab9..1134da6 100644 --- a/src/soc/nvidia/tegra210/include/soc/memlayout.ld +++ b/src/soc/nvidia/tegra210/include/soc/memlayout.ld @@ -38,9 +38,8 @@ STACK(0x4000C400, 3K) #endif TIMESTAMP(0x4000D000, 2K) - BOOTBLOCK(0x4000D800, 30K) - VERSTAGE(0x40015000, 68k) - ROMSTAGE(0x40026000, 104K) + BOOTBLOCK(0x4000D800, 42K) + OVERLAP_VERSTAGE_ROMSTAGE(0x40018000, 160K) SRAM_END(0x40040000)
DRAM_START(0x80000000)
-
Aaron Durbin (Code Review) -
Arthur Heymans (Code Review)
-
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)