Attention is currently required from: Vojtěch Veselý.
Hello Vojtěch Veselý,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/80432?usp=email
to review the following change.
Change subject: util/ifdtool.c: Fix long_options platform has argument ......................................................................
util/ifdtool.c: Fix long_options platform has argument
Currently there is different behavior between using short and long option. Long option causes Segmentation fault.
Change-Id: I7d5c31c2b1da544cb73d9e213d463332fcdba7df Signed-off-by: Vojtech Vesely vojtech.vesely@9elements.com --- M util/ifdtool/ifdtool.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/80432/1
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index e020a8a..516570e 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -2188,7 +2188,7 @@ {"gpr0-enable", 0, NULL, 'E'}, {"version", 0, NULL, 'v'}, {"help", 0, NULL, 'h'}, - {"platform", 0, NULL, 'p'}, + {"platform", 1, NULL, 'p'}, {"validate", 0, NULL, 't'}, {"setpchstrap", 1, NULL, 'S'}, {"newvalue", 1, NULL, 'V'},