Attention is currently required from: Dinesh Gehlot, Edward Doan, Eric Lai, Kapil Porwal, Nick Vaccaro, SH Kim, YH Lin.
Subrata Banik has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/83346?usp=email )
Change subject: mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
we might need to dig deep to find out why the behavior is not identical with other Brya platform that also uses GPP_F14 for Touch as IOAPIC Interrupt. Looks like in your case the only working combination is by making it act as GPI IOxAPIC interrupt. GPI IOxAPIC routed via a GPIO mux hence, i would always prefer to have a dedicated IOAPIC interrupt like other Brya design.
can you please start looking part vendor to understand this issue from device side as well. If there is any overflow of the packet while device FW unable to handle where else changing this to GPI IOxAPIC interrupt reduces the number of IRQ.
Btw, have you tried to change the configuration from LEVEL to Edge Single ?
```
PAD_CFG_GPI_IRQ_WAKE(GPP_F14, NONE, EDGE_SINGLE, INVERT),
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83346?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie1b59355a694e5a42367a20e03f6c5f93225e79c
Gerrit-Change-Number: 83346
Gerrit-PatchSet: 3
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Edward Doan
edoan@chromium.org
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward Doan
edoan@chromium.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Thu, 18 Jul 2024 05:12:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No