Attention is currently required from: Felix Singer, Martin Roth, Paul Menzel, Angel Pons, Patrick Rudolph. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60877 )
Change subject: sb/intel/common/firmware: Hook up adding 10GbE LAN firmware ......................................................................
Patch Set 16:
(1 comment)
File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/60877/comment/64b17b47_769b9136 PS16, Line 168: depends on MAINBOARD_USES_IFD_10GBE_0_REGION
I'd drop this dependency. […]
this is in order to ensure no misconfiguration by an unknowing/careless developer. 10GbE 1 is only supported in combination with 10GbE 0. you *can't* have only 10GbE 1 LAN. it's possible to have a platform that only uses LAN 1 on the board (perhaps for board routing reasons), but the hardware and strapping options can only enable LAN 1 if LAN 0 is also enabled. it *is* possible to have only LAN 0 enabled in hardware/strapping though.
-
Jeff Daly (Code Review)