Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60002 )
Change subject: mb/google/corsola: set up open-drain ChromeOS pins ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60002/comment/4b3d357c_7b6d0677 PS2, Line 7: setup
Set up
Done
https://review.coreboot.org/c/coreboot/+/60002/comment/8db0bb91_c97028c3 PS2, Line 10: GPIO_SAR_INT_ODL/GPIO_BT_WAKE_AP_ODL/GPIO_WIFI_INT_ODL : GPIO_DPBRDG_INT_ODL/GPIO_EDPBRDG_INT_ODL/GPIO_EC_AP_HPD_OD : GPIO_TCHPAD_INT_ODL/GPIO_TCHSCR_INT_1V8_ODL/GPIO_EC_AP_INT_ODL : GPIO_EC_IN_RW_ODL/GPIO_GSC_AP_INT_ODL/GPIO_AP_WP_ODL : GPIO_HP_INT_ODL/GPIO_PEN_EJECT_OD/GPIO_UCAM_DET_ODL
I think you don't need to list all the GPIOs (already in the code); instead you can describe what's […]
Done
https://review.coreboot.org/c/coreboot/+/60002/comment/d363e7a1_d6a8ae83 PS2, Line 15:
Please add the source for these settings.
Done
File src/mainboard/google/corsola/gpio.h:
https://review.coreboot.org/c/coreboot/+/60002/comment/f231e50a_e8812d44 PS3, Line 25: #define GPIO_XHCI_DONE GPIO(PERIPHERAL_EN1)
please, no space before tabs
Please fix.
-
Rex-BC Chen (Code Review)