Attention is currently required from: Bao Zheng, Marshall Dawson, Zheng Bao, ritul guru.
Hello Felix Held, Marshall Dawson, Zheng Bao, build bot (Jenkins), ritul guru,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84530?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: amdfwtool: Set address mode as relative table ......................................................................
amdfwtool: Set address mode as relative table
For the family new than Cezanne, the upper 2 bits defines the address mode. In table header, the address mode of the table is set. In the old code, if the header defines address mode as relative table, the entry address mode is not set. That is not correct.
For A/B recovery, the address mode in Level 2 PSP/BIOS table should be "relative table", including the entry BIOS binary(0x62).
Identidal binary test passes on platforms which are not based on Cezanne, V2000A, Genoa. Booting test passes on Majolica/Cezanne.
Change-Id: I156b315d350d9e7217afc7442ca80277bb7f9095 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/84530/2