Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83288?usp=email )
Change subject: tree: Use <console/console.h> only when needed ......................................................................
tree: Use <console/console.h> only when needed
Change-Id: I3cb1f11beba61afdf2be6188bde9ff135f8ace50 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/arch/arm64/dma.c M src/arch/arm64/smbios.c M src/include/device/dram/rcd.h M src/mainboard/ibm/sbp1/romstage.c M src/soc/intel/xeon_sp/chip_gen6.c M src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h M src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h M src/soc/qualcomm/common/include/soc/usb/qusb_phy.h M src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h M src/soc/qualcomm/common/qupv3_spi.c M src/soc/qualcomm/common/usb/qmpv3_usb_phy.c M src/soc/qualcomm/common/usb/qmpv4_usb_phy.c M src/soc/qualcomm/common/usb/qusb_phy.c M src/soc/qualcomm/common/usb/snps_usb_phy.c M src/superio/ite/it8772f/superio.c 15 files changed, 5 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/83288/1
diff --git a/src/arch/arm64/dma.c b/src/arch/arm64/dma.c index cdeb50f..ec81ab7 100644 --- a/src/arch/arm64/dma.c +++ b/src/arch/arm64/dma.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <stdlib.h>
int dma_coherent(const void *ptr) diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index f0be956..4bf35c4 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -3,7 +3,6 @@ #include <arch/cache.h> #include <arch/lib_helpers.h> #include <arch/smc.h> -#include <console/console.h> #include <smbios.h> #include <stdio.h>
diff --git a/src/include/device/dram/rcd.h b/src/include/device/dram/rcd.h index d0b1f2c..d8429b3 100644 --- a/src/include/device/dram/rcd.h +++ b/src/include/device/dram/rcd.h @@ -5,7 +5,6 @@
#include <types.h> #include <device/i2c_simple.h> -#include <console/console.h>
enum rcw_idx { VEN_ID_L, diff --git a/src/mainboard/ibm/sbp1/romstage.c b/src/mainboard/ibm/sbp1/romstage.c index 489f09f..2c4745e 100644 --- a/src/mainboard/ibm/sbp1/romstage.c +++ b/src/mainboard/ibm/sbp1/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <console/console.h> #include <soc/romstage.h> #include <soc/ddr.h> #include <soc/soc_util.h> diff --git a/src/soc/intel/xeon_sp/chip_gen6.c b/src/soc/intel/xeon_sp/chip_gen6.c index c4462d5..8bbfbe8 100644 --- a/src/soc/intel/xeon_sp/chip_gen6.c +++ b/src/soc/intel/xeon_sp/chip_gen6.c @@ -2,7 +2,6 @@
#include <acpi/acpigen_pci.h> #include <assert.h> -#include <console/console.h> #include <device/pci.h> #include <intelblocks/acpi.h> #include <post.h> diff --git a/src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h b/src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h index a004c79..b9dfb25 100644 --- a/src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h +++ b/src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h @@ -3,7 +3,6 @@ #ifndef __SOC_COMMON_QCOM_QUP_SE_H__ #define __SOC_COMMON_QCOM_QUP_SE_H__
-#include <console/console.h> #include <device/mmio.h> #include <gpio.h> #include <soc/addressmap.h> diff --git a/src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h b/src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h index fc1721a..ad93865 100644 --- a/src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h +++ b/src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/mmio.h> -#include <console/console.h>
/* USB3PHY_PCIE_USB3_PCS_PCS_STATUS bit */ #define USB3_PCS_PHYSTATUS BIT(6) diff --git a/src/soc/qualcomm/common/include/soc/usb/qusb_phy.h b/src/soc/qualcomm/common/include/soc/usb/qusb_phy.h index dd4a736..90c6ff3 100644 --- a/src/soc/qualcomm/common/include/soc/usb/qusb_phy.h +++ b/src/soc/qualcomm/common/include/soc/usb/qusb_phy.h @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/mmio.h> -#include <console/console.h>
#define PORT_TUNE1_MASK 0xf0
diff --git a/src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h b/src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h index de0b385..353aba5 100644 --- a/src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h +++ b/src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/mmio.h> -#include <console/console.h>
struct usb_board_data { /*Register values going to override from the boardfile*/ diff --git a/src/soc/qualcomm/common/qupv3_spi.c b/src/soc/qualcomm/common/qupv3_spi.c index 1bb5c75..5e05d57 100644 --- a/src/soc/qualcomm/common/qupv3_spi.c +++ b/src/soc/qualcomm/common/qupv3_spi.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> +#include <console/console.h> #include <lib.h> #include <soc/clock.h> #include <soc/gpio.h> diff --git a/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c b/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c index c1782be..8c4c339 100644 --- a/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c +++ b/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <console/console.h> #include <timer.h> #include <soc/usb/qmp_usb_phy.h> #include <soc/addressmap.h> diff --git a/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c b/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c index 23ab75a..6a5d7ab 100644 --- a/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c +++ b/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <console/console.h> #include <timer.h> #include <soc/usb/qmp_usb_phy.h> #include <soc/addressmap.h> diff --git a/src/soc/qualcomm/common/usb/qusb_phy.c b/src/soc/qualcomm/common/usb/qusb_phy.c index ddb087f..0defd2f 100644 --- a/src/soc/qualcomm/common/usb/qusb_phy.c +++ b/src/soc/qualcomm/common/usb/qusb_phy.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <console/console.h> #include <soc/usb/qusb_phy.h> #include <soc/efuse.h> #include <timer.h> diff --git a/src/soc/qualcomm/common/usb/snps_usb_phy.c b/src/soc/qualcomm/common/usb/snps_usb_phy.c index d04694b..a7ad7ba 100644 --- a/src/soc/qualcomm/common/usb/snps_usb_phy.c +++ b/src/soc/qualcomm/common/usb/snps_usb_phy.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <console/console.h> #include <soc/usb/snps_usb_phy.h> #include <soc/addressmap.h> #include <commonlib/helpers.h> diff --git a/src/superio/ite/it8772f/superio.c b/src/superio/ite/it8772f/superio.c index 268df0a..662b8a2 100644 --- a/src/superio/ite/it8772f/superio.c +++ b/src/superio/ite/it8772f/superio.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <device/pnp.h> -#include <console/console.h> #include <pc80/keyboard.h> #include <superio/ite/common/env_ctrl.h> #include <arch/io.h>
-
Elyes Haouas (Code Review)