Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43239 )
Change subject: mb/intel/glkrvp: Drop dead code ......................................................................
mb/intel/glkrvp: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: I6948a0b9a6b699cb44e3e02d9e134180bac2fa14 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/43239/1
diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c index 118b49e..56df526 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c +++ b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c @@ -247,10 +247,6 @@
/* GPIO settings before entering sleep. */ static const struct pad_config sleep_gpio_table[] = { -#if 0 - PAD_CFG_GPO(GPIO_150, 0, DEEP), /* NFC_RESET_ODL */ - PAD_CFG_GPI_APIC_LOW(GPIO_20, NONE, DEEP), /* NFC_INT_L */ -#endif };
const struct pad_config * __weak @@ -261,10 +257,6 @@ }
static const struct cros_gpio cros_gpios[] = { -#if 0 - CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), - CROS_GPIO_WP_AH(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), -#endif };
const struct cros_gpio * __weak variant_cros_gpios(size_t *num)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43239 )
Change subject: mb/intel/glkrvp: Drop dead code ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43239 )
Change subject: mb/intel/glkrvp: Drop dead code ......................................................................
mb/intel/glkrvp: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: I6948a0b9a6b699cb44e3e02d9e134180bac2fa14 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43239 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c index 118b49e..56df526 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c +++ b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c @@ -247,10 +247,6 @@
/* GPIO settings before entering sleep. */ static const struct pad_config sleep_gpio_table[] = { -#if 0 - PAD_CFG_GPO(GPIO_150, 0, DEEP), /* NFC_RESET_ODL */ - PAD_CFG_GPI_APIC_LOW(GPIO_20, NONE, DEEP), /* NFC_INT_L */ -#endif };
const struct pad_config * __weak @@ -261,10 +257,6 @@ }
static const struct cros_gpio cros_gpios[] = { -#if 0 - CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), - CROS_GPIO_WP_AH(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), -#endif };
const struct cros_gpio * __weak variant_cros_gpios(size_t *num)