Attention is currently required from: Paul Menzel, Mario Scheithauer. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49462 )
Change subject: mb/siemens/{mc_apl1,...,mc_apl6}: Configure FSP-S UPDs ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49462/comment/3fa34fd0_3fc00914 PS1, Line 25: - Linux booted and checked with 'lspci'
Hi Paul, thanks for reviewing.
Done
File src/mainboard/siemens/mc_apl1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/49462/comment/40558892_e7cf2a75 PS2, Line 188: memcpy This should be memset and not memcpy if I got it right here. Otherwise you will dereference a NULL-pointer.
https://review.coreboot.org/c/coreboot/+/49462/comment/0361a6a1_2fe60831 PS2, Line 192: memcpy Same here.
https://review.coreboot.org/c/coreboot/+/49462/comment/ed0ffa49_2e5a38bb PS2, Line 196: memcpy And here.
-
Werner Zeh (Code Review)