Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 )
Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51145/comment/1f5e51a6_5a807b7e
PS2, Line 72: sx9324
I agree, but I checked with our kernel guy. […]
Ah, I see, I wasn't sure how Gwendal came up with the conversion between the two formats... we'll have to bother Semtech about it I suppose.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc
Gerrit-Change-Number: 51145
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Mar 2021 16:58:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment