Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31888 )
Change subject: soc/intel/cannonlake: Ignore GBE LTR
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/31888/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31888/6//COMMIT_MSG@9
PS6, Line 9: Ignore integrated GBE controller LTR setting to make it wake up from
: s0ix with 10/100M cable attached.
Is that documented or is it a workaround? Why does Latency Tolerance Reporting cause problems?
https://review.coreboot.org/#/c/31888/6//COMMIT_MSG@14
PS6, Line 14: SLP_S0 residency can increase
What does that mean? The system is woken up less?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec7dd197b8a456751f8e4dcb19e3e153f5888613
Gerrit-Change-Number: 31888
Gerrit-PatchSet: 6
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: Roy Park
roy.mingi.park@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Mar 2019 19:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment