Attention is currently required from: Mario Scheithauer, Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56631 )
Change subject: mb/siemens/mc_ehl: Add code to wait for legacy devices before PCI scan
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/siemens/mc_ehl/mainboard.c:
https://review.coreboot.org/c/coreboot/+/56631/comment/8036f2ec_79c642ca
PS1, Line 91: uint32_t
Done
What other places are there? Using 32-bit type implies some restriction on the value, which seems unnecessary. In this case `get_us_since_boot()` returns uint32_t, which I did not check before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2f935b69ddaa9364566deacfada5e7d41fcdabd
Gerrit-Change-Number: 56631
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 28 Jul 2021 12:36:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment