Anil Kumar K has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43620 )
Change subject: mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER ......................................................................
mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER
- Update MAINBOARD_PART_NUMBER for TGL variants - MAINBOARD_PART_NUMBER is reported as FRID on acpi - This is required for cros_config to differentiate across TGL variants. - Mosys uses cros_config to identify TGL variants using data read from FRID
Bug=none Test=build and boot coreboot on TGLRVP UP3 hardware
Signed-off-by: Anil Kumar anil.kumar.k@intel.com Change-Id: I11d4ab2a5b6ade6c50988a9fec4d9866fe79d7b5 --- M src/mainboard/intel/tglrvp/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/43620/1
diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 867c88e..515a0d9 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -46,7 +46,10 @@
config MAINBOARD_PART_NUMBER string - default "tglrvp" + default "tglrvpu" if BOARD_INTEL_TGLRVP_UP3 + default "tglrvpy" if BOARD_INTEL_TGLRVP_UP4 + default "tglrvpu_b0" if BOARD_INTEL_TGLRVP_UP3_B0 + default "tglrvpy_b0" if BOARD_INTEL_TGLRVP_UP4_B0
config MAINBOARD_FAMILY string
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43620 )
Change subject: mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Wonkyu Kim, Jack Rosenthal, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43620
to look at the new patch set (#2).
Change subject: mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER ......................................................................
mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER
- Update MAINBOARD_PART_NUMBER for TGL variants - MAINBOARD_PART_NUMBER is reported as FRID on acpi - This is required for cros_config to differentiate across TGL variants. - Mosys uses cros_config to identify TGL variants using data read from FRID
Bug=none Test=build and boot coreboot on TGLRVP UP3 hardware
Signed-off-by: Anil Kumar anil.kumar.k@intel.com Change-Id: I11d4ab2a5b6ade6c50988a9fec4d9866fe79d7b5 --- M src/mainboard/intel/tglrvp/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/43620/2
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43620 )
Change subject: mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER ......................................................................
Patch Set 2: Code-Review+1
Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43620 )
Change subject: mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER ......................................................................
Patch Set 2: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43620 )
Change subject: mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER ......................................................................
Patch Set 2: Code-Review+2
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43620 )
Change subject: mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43620 )
Change subject: mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER ......................................................................
mb/intel/tglrvp: Update MAINBOARD_PART_NUMBER
- Update MAINBOARD_PART_NUMBER for TGL variants - MAINBOARD_PART_NUMBER is reported as FRID on acpi - This is required for cros_config to differentiate across TGL variants. - Mosys uses cros_config to identify TGL variants using data read from FRID
Bug=none Test=build and boot coreboot on TGLRVP UP3 hardware
Signed-off-by: Anil Kumar anil.kumar.k@intel.com Change-Id: I11d4ab2a5b6ade6c50988a9fec4d9866fe79d7b5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43620 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jack Rosenthal jrosenth@chromium.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com --- M src/mainboard/intel/tglrvp/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Srinidhi N Kaushik: Looks good to me, approved Wonkyu Kim: Looks good to me, approved Jack Rosenthal: Looks good to me, but someone else must approve Anil Kumar K: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 867c88e..2acd68a 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -46,7 +46,8 @@
config MAINBOARD_PART_NUMBER string - default "tglrvp" + default "tglrvpu" if BOARD_INTEL_TGLRVP_UP3 + default "tglrvpy" if BOARD_INTEL_TGLRVP_UP4
config MAINBOARD_FAMILY string
-
Anil Kumar K (Code Review) -
Jack Rosenthal (Code Review)
-
Patrick Georgi (Code Review)
-
Srinidhi N Kaushik (Code Review)
-
Wonkyu Kim (Code Review)