Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email )
Change subject: soc/mediatek/mt8196: Add MT6685 adc init
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85734/comment/f84fbcab_14aa70cd?usp... :
PS5, Line 7: adc init
Clock IC driver
https://review.coreboot.org/c/coreboot/+/85734/comment/b2678bac_a7280d2d?usp... :
PS5, Line 8:
`'intial' may be misspelled - perhaps 'initial'?`
Please fix.
https://review.coreboot.org/c/coreboot/+/85734/comment/de971fc5_fa65b8a6?usp... :
PS5, Line 9: and MT6685 ADC SW intial settings
and ADC init settings
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85734?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e
Gerrit-Change-Number: 85734
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 25 Dec 2024 03:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No