Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55316 )
Change subject: arch/x86/ioapic: Reduce API exposure ......................................................................
arch/x86/ioapic: Reduce API exposure
Change-Id: I6ff18e5ede0feda65f81c064394febd3eebc5247 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/55316 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/include/arch/ioapic.h M src/arch/x86/ioapic.c 2 files changed, 17 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/arch/x86/include/arch/ioapic.h b/src/arch/x86/include/arch/ioapic.h index 288f54c..12f9387 100644 --- a/src/arch/x86/include/arch/ioapic.h +++ b/src/arch/x86/include/arch/ioapic.h @@ -26,9 +26,6 @@ #define SMI (2 << 8) #define INT (1 << 8)
-u32 io_apic_read(void *ioapic_base, u32 reg); -void io_apic_write(void *ioapic_base, u32 reg, u32 value); -void set_ioapic_id(void *ioapic_base, u8 ioapic_id); u8 get_ioapic_id(void *ioapic_base); u8 get_ioapic_version(void *ioapic_base);
diff --git a/src/arch/x86/ioapic.c b/src/arch/x86/ioapic.c index 1440bb4..28bbcb1 100644 --- a/src/arch/x86/ioapic.c +++ b/src/arch/x86/ioapic.c @@ -6,13 +6,13 @@ #include <console/console.h> #include <cpu/x86/lapic.h>
-u32 io_apic_read(void *ioapic_base, u32 reg) +static u32 io_apic_read(void *ioapic_base, u32 reg) { write32(ioapic_base, reg); return read32(ioapic_base + 0x10); }
-void io_apic_write(void *ioapic_base, u32 reg, u32 value) +static void io_apic_write(void *ioapic_base, u32 reg, u32 value) { write32(ioapic_base, reg); write32(ioapic_base + 0x10, value); @@ -108,7 +108,7 @@ } }
-void set_ioapic_id(void *ioapic_base, u8 ioapic_id) +static void set_ioapic_id(void *ioapic_base, u8 ioapic_id) { int i;