Change in coreboot[master]: src/security/vboot: Set up secure counter space in TPM NVRAM
Attention is currently required from: Andrey Pronin, Raul Rangel, Paul Menzel, Julius Werner, Yu-Ping Wu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59476 )
Change subject: src/security/vboot: Set up secure counter space in TPM NVRAM ......................................................................
Patch Set 6:
(4 comments)
File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/59476/comment/c9d6286f_0e47ca15 PS4, Line 289: Setup
Set up
Done
File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/59476/comment/6dac73fa_26334582 PS3, Line 32: 0x100f
What about moving this a bit away from the other indices so it can grow on its own when necessary? M […]
Done
File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/59476/comment/3d966f86_744b578e PS2, Line 39: SECURE_COUNTER1_NV_INDEX
Well, they aren't really (I think?), counters are part of the TPM 2.0 standard.
Please refer below discussion. Marking it as resolved for now.
https://review.coreboot.org/c/coreboot/+/59476/comment/85c27d55_f78e9c77 PS2, Line 42: #define SECURE_COUNTER4_NV_INDEX 0x1012
Not really sure what you mean by cr50 specific. […]
Since any index can be picked, this is not Cr50 specific.
-
Karthik Ramasubramanian (Code Review)