Tao Xia has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
mb/google/kukui: Fix LCD sequence T3 fail issue
There is a delay between PPVARN_LCD_EN and PPVARN_LCD. An extra 9ms delay should be added on LCM_RST_1V8 in order to meet the Spec.
BUG=b:172201138 BRANCH=kukui TEST=The LCD sequence T3 is larger than 5ms when power on.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: Iaf7ae494e30c4c207103d949287b335288688c54 --- M src/mainboard/google/kukui/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/47443/1
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 268b7ca..cbcb5da 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -91,7 +91,7 @@ gpio_output(GPIO_PPVARN_LCD_EN, 1); gpio_output(GPIO_PP1800_LCM_EN, 1); gpio_output(GPIO_PP3300_LCM_EN, 1); - mdelay(6); + mdelay(15); gpio_output(GPIO_LCM_RST_1V8, 1); mdelay(6); }
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47443/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47443/1//COMMIT_MSG@10 PS1, Line 10: to meet the Spec. please provide the name of spec so we can find reference in future.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47443/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47443/1//COMMIT_MSG@10 PS1, Line 10: An The first few words and be merged into the previous line. Make sure line length <= 72 chars.
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47443
to look at the new patch set (#2).
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
mb/google/kukui: Fix LCD sequence T3 fail issue
There is a delay between PPVARN_LCD_EN and PPVARN_LCD.An extra 9ms delay should be added on LCM_RST_1V8 in order to meet the Spec "ProductSpec_NV105WUM-A51_V4.3_P2(TLCM).pdf".
BUG=b:172201138 BRANCH=kukui TEST=The LCD sequence T3 is larger than 5ms when power on.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: Iaf7ae494e30c4c207103d949287b335288688c54 --- M src/mainboard/google/kukui/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/47443/2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47443/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47443/1//COMMIT_MSG@10 PS1, Line 10: An
The first few words and be merged into the previous line. Make sure line length <= 72 chars.
Done
https://review.coreboot.org/c/coreboot/+/47443/1//COMMIT_MSG@10 PS1, Line 10: to meet the Spec.
please provide the name of spec so we can find reference in future.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
Patch Set 2:
(3 comments)
(15 ms is quite long for coreboot standards.)
https://review.coreboot.org/c/coreboot/+/47443/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47443/2//COMMIT_MSG@8 PS2, Line 8: Please describe the problem first.
https://review.coreboot.org/c/coreboot/+/47443/2//COMMIT_MSG@9 PS2, Line 9: PPVARN_LCD.An Please add a space after the dot/period.
https://review.coreboot.org/c/coreboot/+/47443/2//COMMIT_MSG@10 PS2, Line 10: Spec spec
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47443
to look at the new patch set (#3).
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
mb/google/kukui: Fix LCD sequence T3 fail issue
The T3 that PPVARN_LCD low to LCM_RST_1V8 high is 0.1269ms and it does not meet the LCD specification that the T3 must be larger than 5ms. Because there is a delay between PPVARN_LCD_EN and PPVARN_LCD. An extra 9ms delay should be added on LCM_RST_1V8 in order to meet the specification "ProductSpec_NV105WUM-A51_ V4.3_P2(TLCM).pdf".
BUG=b:172201138 BRANCH=kukui TEST=The LCD sequence T3 is larger than 5ms when power on.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: Iaf7ae494e30c4c207103d949287b335288688c54 --- M src/mainboard/google/kukui/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/47443/3
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
Patch Set 3: Code-Review+2
the build failure seems not related to this patch.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47443/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47443/2//COMMIT_MSG@8 PS2, Line 8:
Please describe the problem first.
Ack
https://review.coreboot.org/c/coreboot/+/47443/2//COMMIT_MSG@9 PS2, Line 9: PPVARN_LCD.An
Please add a space after the dot/period.
Ack
https://review.coreboot.org/c/coreboot/+/47443/2//COMMIT_MSG@10 PS2, Line 10: Spec
spec
Ack
Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
Patch Set 3:
Hi Hung-Te,
This CL is still in Active state. Please help to merge it ASAP. Thank you.
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47443 )
Change subject: mb/google/kukui: Fix LCD sequence T3 fail issue ......................................................................
mb/google/kukui: Fix LCD sequence T3 fail issue
The T3 that PPVARN_LCD low to LCM_RST_1V8 high is 0.1269ms and it does not meet the LCD specification that the T3 must be larger than 5ms. Because there is a delay between PPVARN_LCD_EN and PPVARN_LCD. An extra 9ms delay should be added on LCM_RST_1V8 in order to meet the specification "ProductSpec_NV105WUM-A51_ V4.3_P2(TLCM).pdf".
BUG=b:172201138 BRANCH=kukui TEST=The LCD sequence T3 is larger than 5ms when power on.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: Iaf7ae494e30c4c207103d949287b335288688c54 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47443 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/mainboard/google/kukui/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 268b7ca..cbcb5da 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -91,7 +91,7 @@ gpio_output(GPIO_PPVARN_LCD_EN, 1); gpio_output(GPIO_PP1800_LCM_EN, 1); gpio_output(GPIO_PP3300_LCM_EN, 1); - mdelay(6); + mdelay(15); gpio_output(GPIO_LCM_RST_1V8, 1); mdelay(6); }
-
Hung-Te Lin (Code Review) -
Paul Menzel (Code Review)
-
Tao Xia (Code Review)
-
Yu-Ping Wu (Code Review)