Attention is currently required from: Felix Singer, Martin L Roth, Nico Huber, Torsten Schenk.
Julius Werner has posted comments on this change by Torsten Schenk. ( https://review.coreboot.org/c/coreboot/+/83379?usp=email )
Change subject: Makefile: unexport CFLAGS ......................................................................
Patch Set 1:
(1 comment)
File Makefile:
https://review.coreboot.org/c/coreboot/+/83379/comment/8846fb67_51cee334?usp... : PS1, Line 7: unexport CFLAGS
I think this is the wrong way to go about this. […]
I agree in general. AFAIU the problem here isn't actually in coreboot, it's in libpayload which unfortunately still uses raw CFLAGS for firmware code. For that reason, I suggested that the libpayload Makefile should clear CFLAGS at the top instead. A better solution (but with more effort) would be to rewrite the libpayload Makefiles so they don't use raw CFLAGS at all, like coreboot.
For util/marvell/doimage_mv/Makefile.mk I think the current usage is fine because that's a host utility, there using CFLAGS from the environment is expected and consistent with how many Linux userspace utilities are built. Some (but not all) other coreboot userspace utilities do that too (e.g. cbmem).