Attention is currently required from: Tim Wawrzynczak, Wisley Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59267 )
Change subject: mb/google/brya/var/redrix: Correct WWAN power sequence ......................................................................
Patch Set 1:
(7 comments)
File src/mainboard/google/brya/variants/redrix/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133166): https://review.coreboot.org/c/coreboot/+/59267/comment/5a5a4d66_2a406106 PS1, Line 98: /* E0 : SATAXPCIE0 ==> WWAN_PERST_L (updated in ramstage) */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133166): https://review.coreboot.org/c/coreboot/+/59267/comment/c60e00fe_d875503d PS1, Line 125: /* B4 : PROC_GP3 ==> SSD_PERST_L */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133166): https://review.coreboot.org/c/coreboot/+/59267/comment/23eaf0fa_114c587a PS1, Line 126: PAD_CFG_GPO(GPP_B4, 1, DEEP), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133166): https://review.coreboot.org/c/coreboot/+/59267/comment/766d9d22_2dd545db PS1, Line 126: PAD_CFG_GPO(GPP_B4, 1, DEEP), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133166): https://review.coreboot.org/c/coreboot/+/59267/comment/b66a7cfe_e3227809 PS1, Line 127: /* F21 : EXT_PWR_GATE2# ==> WWAN_FCPO_L (set here for correct power sequencing) */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133166): https://review.coreboot.org/c/coreboot/+/59267/comment/458cfca6_68d4ba70 PS1, Line 128: PAD_CFG_GPO(GPP_F21, 1, DEEP), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133166): https://review.coreboot.org/c/coreboot/+/59267/comment/665d2c3c_b856e1bd PS1, Line 128: PAD_CFG_GPO(GPP_F21, 1, DEEP), please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)