Attention is currently required from: Arthur Heymans, Jakub Czapiga, Julius Werner, Lean Sheng Tan, Matt DeVillier, Philipp Hug, Ron Minnich, Simon Glass.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/76591?usp=email )
Change subject: [RFC] Add UPL FDT handoff ......................................................................
Patch Set 18:
(4 comments)
This change is ready for review.
File payloads/Kconfig:
https://review.coreboot.org/c/coreboot/+/76591/comment/687e677c_3b6bd9c8?usp... : PS17, Line 194: # payload none only implies that we don't build with a payload, but it can later be added via CBFS, which makes creating handoff still necessary. : choice
I think that this shouldn't use a choice - we may want one or both enabled.
You can't have both. Either you pass FDT as argument to the payload or coreboot tables.
File payloads/libpayload/arch/arm/coreboot.c:
https://review.coreboot.org/c/coreboot/+/76591/comment/aaf82c67_bfec1531?usp... : PS17, Line 60: if (CONFIG(LP_UPL))
You could just have a look at the cb_header_ptr to see what kind of handoff it is at runtime.
Sure but you would always need to compile in both handoffs. Not sure if that is worth the tradeoff.
File src/drivers/uart/pl011.c:
https://review.coreboot.org/c/coreboot/+/76591/comment/3abe4986_3e8db76a?usp... : PS15, Line 84: //TODO test
still a todo?
Done
File src/drivers/uart/uart8250io.c:
https://review.coreboot.org/c/coreboot/+/76591/comment/5be2592a_5f61255b?usp... : PS15, Line 138: #define FDT_IORESOURCE_FLAG 0x100000000
it just jumped out at me as being unusual, if nobody else has a problem with it, then I'm good with […]
Acknowledged
-
Maximilian Brune (Code Review)