Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76024?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableGt dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableGt dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="FastPkgCRampDisableGt" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: Ie56967088c1aa955008d61d162eaf1a5ae135860 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb M src/mainboard/google/hatch/variants/mushu/overridetree.cb M src/mainboard/purism/librem_cnl/devicetree.cb 5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/76024/1
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index f60b818..9880935 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -24,7 +24,7 @@ register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register FastPkgCRampDisableIa = true - register "FastPkgCRampDisableGt" = "1" + register FastPkgCRampDisableGt = true register "FastPkgCRampDisableSa" = "1"
# Intel Common SoC Config diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 1a96b83..0150fcc 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -21,7 +21,7 @@ register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "2" register FastPkgCRampDisableIa = true - register "FastPkgCRampDisableGt" = "1" + register FastPkgCRampDisableGt = true register "FastPkgCRampDisableSa" = "1"
# Intel Common SoC Config diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index 86c3d8d..f4f6ffc 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -24,7 +24,7 @@ register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register FastPkgCRampDisableIa = true - register "FastPkgCRampDisableGt" = "1" + register FastPkgCRampDisableGt = true register "FastPkgCRampDisableSa" = "1"
# Intel Common SoC Config diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb index 3c1d53c..eba388d 100644 --- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb +++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb @@ -21,7 +21,7 @@ register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "2" register FastPkgCRampDisableIa = true - register "FastPkgCRampDisableGt" = "1" + register FastPkgCRampDisableGt = true register "FastPkgCRampDisableSa" = "1"
register "power_limits_config" = "{ diff --git a/src/mainboard/purism/librem_cnl/devicetree.cb b/src/mainboard/purism/librem_cnl/devicetree.cb index 4914bba..c6fffed 100644 --- a/src/mainboard/purism/librem_cnl/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/devicetree.cb @@ -12,7 +12,7 @@ register AcousticNoiseMitigation = true
register FastPkgCRampDisableIa = true - register "FastPkgCRampDisableGt" = "1" + register FastPkgCRampDisableGt = true register "FastPkgCRampDisableSa" = "1" register "FastPkgCRampDisableFivr" = "1"