Hello Felix Singer, build bot (Jenkins), Nico Huber, Patrick Georgi, Jeremy Soller, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43644
to look at the new patch set (#17).
Change subject: mb/system76/lemp9: gpio: configure unused pads ......................................................................
mb/system76/lemp9: gpio: configure unused pads
There are pads being unused for various reasons: a) missing board support (DeepSx: SUSWARN#) b) unneeded feature ID pins - currently no known device models without keyboard backlight - currently no known device models without TPM c) BOARD_ID (L140CU/L140ZU) is fixed and known at build time d) DDR_TYPE_*: there is only one known ram model e) strap-only pads f) unconnected pads
Configure them as NC with appropriate pull-up if no external pull exists. The latter was checked by schematics and looking at the board.
When any of the unused ID pins is needed in the future, they can be reactivated easily (configure as GPI).
Further, convert from use of legacy macro PAD_CFG_NC to PAD_NC.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: Ia370c180d5ae6f48360be14af3cbab29e6814e75 --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 186 insertions(+), 188 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/43644/17