Attention is currently required from: Elyes Haouas, Paul Menzel.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/63716?usp=email )
Change subject: util/cbfstool: Rewrite trampoline in C ......................................................................
Patch Set 4:
(3 comments)
File util/cbfstool/x86_linux_trampoline.c:
https://review.coreboot.org/c/coreboot/+/63716/comment/1c182d35_20ec2155?usp... : PS1, Line 62: Setup
Set up
Done
https://review.coreboot.org/c/coreboot/+/63716/comment/58155ca3_21a9558c?usp... : PS1, Line 63: ** : ** Flat code segment descriptor: : ** selector: 0x10 : ** base : 0x00000000 : ** limit : 0xFFFFFFFF : ** type : code, execute, read : ** : ** Flat data segment descriptor: : ** selector: 0x18 : ** base : 0x00000000 : ** limit : 0xFFFFFFFF : ** type : data, read/write
Remove the first *?
Done
File util/cbfstool/x86_linux_trampoline.c:
https://review.coreboot.org/c/coreboot/+/63716/comment/efb4556b_63362497?usp... : PS4, Line 6: <commonlib/bsd/compiler.h>
is always automatically included in all compilation units. See `git grep -F 'compiler.h' $(find -type f -name "*.mk")` `nano +893 Documentation/contributing/coding_style.md`
I don't do this the commandline.