Change in coreboot[master]: src: Remove unused 'include <string.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41913 )

Change subject: src: Remove unused 'include <string.h>'
......................................................................

src: Remove unused 'include <string.h>'

Found using:
diff <(git grep -l '#include <string.h>' -- src/) <(git grep -l 'STRINGIFY|memcpy|memmove|memset|memcmp|memchr|strdup|strconcat|strnlen|strlen|strchr|strncpy|strcpy|strcmp|strncmp|strspn|strcspn|strtok_r|strtok|atol|strrchr|skip_atoi|snprintf' -- src/) |grep -v vendorcode |grep '<'

Change-Id: I12802d0a6254b2fa39d59f485008bb2012f7b32d
Signed-off-by: Elyes HAOUAS 
---
M src/acpi/soundwire.c
M src/mainboard/dell/optiplex_9010/sch5545_ec.c
2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/41913/1

diff --git a/src/acpi/soundwire.c b/src/acpi/soundwire.c
index 341114a..701fe2a 100644
--- a/src/acpi/soundwire.c
+++ b/src/acpi/soundwire.c
@@ -6,7 +6,6 @@
 #include <commonlib/helpers.h>
 #include <device/soundwire.h>
 #include <stdbool.h>
-#include <string.h>

/* Specification-defined prefix for SoundWire properties. */
 #define SDW_PFX "mipi-sdw-"
diff --git a/src/mainboard/dell/optiplex_9010/sch5545_ec.c b/src/mainboard/dell/optiplex_9010/sch5545_ec.c
index 4013452..2719460 100644
--- a/src/mainboard/dell/optiplex_9010/sch5545_ec.c
+++ b/src/mainboard/dell/optiplex_9010/sch5545_ec.c
@@ -2,7 +2,6 @@

#include <cbfs.h>
 #include <cf9_reset.h>
-#include <string.h>
 #include <option.h>
 #include <arch/io.h>
 #include <cpu/x86/msr.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41913

to look at the new patch set (#5).

Change subject: src: Remove unused 'include <string.h>'
......................................................................

src: Remove unused 'include <string.h>'

Found using:
diff <(git grep -l '#include <string.h>' -- src/) <(git grep -l 'STRINGIFY|memcpy|memmove|memset|memcmp|memchr|strdup|strconcat|strnlen|strlen|strchr|strncpy|strcpy|strcmp|strncmp|strspn|strcspn|strtok_r|strtok|atol|strrchr|skip_atoi|snprintf' -- src/) |grep -v vendorcode |grep '<'

Change-Id: I12802d0a6254b2fa39d59f485008bb2012f7b32d
Signed-off-by: Elyes HAOUAS 
---
M src/acpi/soundwire.c
M src/mainboard/dell/optiplex_9010/sch5545_ec.c
2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/41913/5

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41913 )

Change subject: src: Remove unused 'include <string.h>'
......................................................................

Abandoned

see 42340

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/41913 )

Change subject: src: Remove unused 'include <string.h>'
......................................................................

Restored

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41913

to look at the new patch set (#9).

Change subject: src: Remove unused 'include <string.h>'
......................................................................

src: Remove unused 'include <string.h>'

Found using:
diff <(git grep -l '#include <string.h>' -- src/) <(git grep -l 'STRINGIFY|memcpy|memmove|memset|memcmp|memchr|strdup|strconcat|strnlen|strlen|strchr|strncpy|strcpy|strcmp|strncmp|strspn|strcspn|strtok_r|strtok|atol|strrchr|skip_atoi|snprintf' -- src/) |grep -v vendorcode |grep '<'

Change-Id: I12802d0a6254b2fa39d59f485008bb2012f7b32d
Signed-off-by: Elyes HAOUAS 
---
M src/acpi/soundwire.c
M src/mainboard/dell/optiplex_9010/sch5545_ec.c
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/southbridge/amd/agesa/hudson/fadt.c
M src/southbridge/amd/cimx/sb800/fadt.c
M src/southbridge/amd/pi/hudson/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/i82801dx/fadt.c
M src/southbridge/intel/i82801gx/fadt.c
M src/southbridge/intel/i82801ix/fadt.c
M src/southbridge/intel/i82801jx/fadt.c
11 files changed, 0 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/41913/9

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41913 )

Change subject: src: Remove unused 'include <string.h>'
......................................................................

Patch Set 10: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41913 )

Change subject: src: Remove unused 'include <string.h>'
......................................................................

src: Remove unused 'include <string.h>'

Found using:
diff <(git grep -l '#include <string.h>' -- src/) <(git grep -l 'STRINGIFY|memcpy|memmove|memset|memcmp|memchr|strdup|strconcat|strnlen|strlen|strchr|strncpy|strcpy|strcmp|strncmp|strspn|strcspn|strtok_r|strtok|atol|strrchr|skip_atoi|snprintf' -- src/) |grep -v vendorcode |grep '<'

Change-Id: I12802d0a6254b2fa39d59f485008bb2012f7b32d
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41913
Reviewed-by: Patrick Georgi 
Tested-by: build bot (Jenkins) 
---
M src/acpi/soundwire.c
M src/mainboard/dell/optiplex_9010/sch5545_ec.c
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/southbridge/amd/agesa/hudson/fadt.c
M src/southbridge/amd/cimx/sb800/fadt.c
M src/southbridge/amd/pi/hudson/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/i82801dx/fadt.c
M src/southbridge/intel/i82801gx/fadt.c
M src/southbridge/intel/i82801ix/fadt.c
M src/southbridge/intel/i82801jx/fadt.c
11 files changed, 0 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/acpi/soundwire.c b/src/acpi/soundwire.c
index 1151a18..ed3634d 100644
--- a/src/acpi/soundwire.c
+++ b/src/acpi/soundwire.c
@@ -7,7 +7,6 @@
 #include <device/soundwire.h>
 #include <stdbool.h>
 #include <stdint.h>
-#include <string.h>

/* Specification-defined prefix for SoundWire properties. */
 #define SDW_PFX "mipi-sdw-"
diff --git a/src/mainboard/dell/optiplex_9010/sch5545_ec.c b/src/mainboard/dell/optiplex_9010/sch5545_ec.c
index 4013452..2719460 100644
--- a/src/mainboard/dell/optiplex_9010/sch5545_ec.c
+++ b/src/mainboard/dell/optiplex_9010/sch5545_ec.c
@@ -2,7 +2,6 @@

#include <cbfs.h>
 #include <cf9_reset.h>
-#include <string.h>
 #include <option.h>
 #include <arch/io.h>
 #include <cpu/x86/msr.h>
diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c
index 51baae5..104e5d0 100644
--- a/src/mainboard/emulation/qemu-q35/acpi_tables.c
+++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <types.h>
-#include <string.h>
 #include <acpi/acpi.h>
 #include <acpi/acpi_gnvs.h>
 #include <arch/ioapic.h>
diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c
index bb86d5f..e3b1647 100644
--- a/src/southbridge/amd/agesa/hudson/fadt.c
+++ b/src/southbridge/amd/agesa/hudson/fadt.c
@@ -4,7 +4,6 @@
  * ACPI - create the Fixed ACPI Description Tables (FADT)
  */

-#include <string.h>
 #include <console/console.h>
 #include <acpi/acpi.h>
 #include <device/device.h>
diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c
index 4bca136..379205a 100644
--- a/src/southbridge/amd/cimx/sb800/fadt.c
+++ b/src/southbridge/amd/cimx/sb800/fadt.c
@@ -5,8 +5,6 @@
  * ACPI - create the Fixed ACPI Description Tables (FADT)
  */

-
-#include <string.h>
 #include <console/console.h>
 #include <acpi/acpi.h>
 #include <arch/io.h>
diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c
index a243252..a8bc9c2 100644
--- a/src/southbridge/amd/pi/hudson/fadt.c
+++ b/src/southbridge/amd/pi/hudson/fadt.c
@@ -4,7 +4,6 @@
  * ACPI - create the Fixed ACPI Description Tables (FADT)
  */

-#include <string.h>
 #include <console/console.h>
 #include <acpi/acpi.h>
 #include <device/device.h>
diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 84745a4..5086992 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -4,7 +4,6 @@
  * Based on src/southbridge/via/vt8237r/vt8237_fadt.c
  */

-#include <string.h>
 #include <acpi/acpi.h>
 #include <device/device.h>
 #include <device/pci.h>
diff --git a/src/southbridge/intel/i82801dx/fadt.c b/src/southbridge/intel/i82801dx/fadt.c
index 2da2175..4d1a615 100644
--- a/src/southbridge/intel/i82801dx/fadt.c
+++ b/src/southbridge/intel/i82801dx/fadt.c
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-#include <string.h>
 #include <device/pci_ops.h>
 #include <acpi/acpi.h>
 #include <version.h>
diff --git a/src/southbridge/intel/i82801gx/fadt.c b/src/southbridge/intel/i82801gx/fadt.c
index dca4bb4..3ab4911 100644
--- a/src/southbridge/intel/i82801gx/fadt.c
+++ b/src/southbridge/intel/i82801gx/fadt.c
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-#include <string.h>
 #include <device/pci_ops.h>
 #include <acpi/acpi.h>
 #include <cpu/x86/smm.h>
diff --git a/src/southbridge/intel/i82801ix/fadt.c b/src/southbridge/intel/i82801ix/fadt.c
index 7a38408..3b657ad 100644
--- a/src/southbridge/intel/i82801ix/fadt.c
+++ b/src/southbridge/intel/i82801ix/fadt.c
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-#include <string.h>
 #include <device/pci_ops.h>
 #include <acpi/acpi.h>
 #include <cpu/x86/smm.h>
diff --git a/src/southbridge/intel/i82801jx/fadt.c b/src/southbridge/intel/i82801jx/fadt.c
index c0a9d53..c00aa74 100644
--- a/src/southbridge/intel/i82801jx/fadt.c
+++ b/src/southbridge/intel/i82801jx/fadt.c
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-#include <string.h>
 #include <device/pci_ops.h>
 #include <acpi/acpi.h>
 #include <cpu/x86/smm.h>