Attention is currently required from: Tarun Tuli, SRIDHAR SIRICILLA, Kapil Porwal, Dinesh Gehlot, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74388 )
Change subject: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74388/comment/778f0c85_ba5b0cb1
PS6, Line 1219: vboot_recovery_mode_enabled
This seems to be redundant considering the execution path starting from store_ish_version()
yeah, i will drop that over an incremental cl. hope that is good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74388
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac
Gerrit-Change-Number: 74388
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: SRIDHAR SIRICILLA
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Mon, 17 Apr 2023 09:36:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment