Attention is currently required from: Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59494 )
Change subject: libpayload/libc/fmap: Implement new FlashMap API ......................................................................
Patch Set 9:
(3 comments)
Patchset:
PS7:
Well, the patch is landed now so it should definitely be included in Jenkins builds. […]
Ok, I know, what is happening here. coreinfo and nvramciu are using lpgcc, which does not pass commonlib/bsd include paths to GCC. Can you take a look at the potential fix? -> CB:60171
File payloads/libpayload/tests/libc/fmap_locate_area-test.c:
https://review.coreboot.org/c/coreboot/+/59494/comment/085536cb_2598874e PS6, Line 98: _fmap_cache = NULL;
Hmm... yeah... why does it call free() anyway? I don't see you malloc() it anywhere.
Right, free() is not needed.
File payloads/libpayload/tests/libc/fmap_locate_area-test.c:
https://review.coreboot.org/c/coreboot/+/59494/comment/2e6c51ff_34f59a1c PS7, Line 78: u8 fmap_buffer2[sizeof(struct fmap) + 3 * sizeof(struct fmap_area)];
Is this still used?
Done
-
Jakub Czapiga (Code Review)