[M] Change in coreboot[main]: mb/google/rauru: Add support for getting storage id

[Jarried Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85717?usp=email )

Change subject: mb/google/rauru: Add support for getting storage id
......................................................................

Patch Set 3:

(8 comments)

File src/mainboard/google/rauru/boardid.c:

https://review.coreboot.org/c/coreboot/+/85717/comment/c53fa90c_6c448986?usp... :
PS1, Line 14: SKU IDs
> Storage ID

Done

https://review.coreboot.org/c/coreboot/+/85717/comment/84118de7_559699f3?usp... :
PS1, Line 16: STORAGE_ID_HIGH_CHANNEL
> Do we need this if not used?

Done

https://review.coreboot.org/c/coreboot/+/85717/comment/0301861b_72a55eb8?usp... :
PS1, Line 57: panel
> storage

Done

https://review.coreboot.org/c/coreboot/+/85717/comment/1b3b6f8b_e4ad7182?usp... :
PS1, Line 61: 	printk(BIOS_DEBUG, "Storage ID: %#02x\n", cached_panel_id);
> insert the blank line on above

Done

https://review.coreboot.org/c/coreboot/+/85717/comment/73d6bc13_c09093e9?usp... :
PS1, Line 62:
> remove this blank line

Done

File src/mainboard/google/rauru/mainboard.c:

https://review.coreboot.org/c/coreboot/+/85717/comment/fee1fe96_4f2a0241?usp... :
PS1, Line 14: #include <soc/mt6363_sdmadc.h>
> remove ?

Done

https://review.coreboot.org/c/coreboot/+/85717/comment/dba70376_8e80f01d?usp... :
PS1, Line 60: 	mt6363_init_pmif_arb();
            : 	mt6363_enable_vtref18(true);
            : 	mt6363_set_vtref18_voltage(1800000);
            : 	mt6363_get_vtref18_voltage();
> An alternative is powering on `vtref18` in `storage_id` (since this power rail is board-specific des […]

Done

https://review.coreboot.org/c/coreboot/+/85717/comment/f93b076e_7269baa1?usp... :
PS1, Line 63: 	mt6363_get_vtref18_voltage();
> Remove `mt6363_get_vtref18_voltage`. It is not needed.

Done