Hello Frans Hendriks,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37609
to review the following change.
Change subject: mb/{facebook/portwell}: Remove ITE8258_CMD_PORT ......................................................................
mb/{facebook/portwell}: Remove ITE8258_CMD_PORT
ITE8258_CMD_PORT is used in com_init.c only. Replace ITE8258_CMD_PORT by fixed value in the c file. ITE8258_DATA_PORT is removed as this isn't used.
BUG=N/A TEST=build
Change-Id: I401da3f127db9e65763fd8d115eb274fbadbefbe Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/com_init.c M src/mainboard/facebook/fbg1701/onboard.h M src/mainboard/portwell/m107/com_init.c M src/mainboard/portwell/m107/onboard.h 4 files changed, 2 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/37609/1
diff --git a/src/mainboard/facebook/fbg1701/com_init.c b/src/mainboard/facebook/fbg1701/com_init.c index f19aba3..fc640dd 100644 --- a/src/mainboard/facebook/fbg1701/com_init.c +++ b/src/mainboard/facebook/fbg1701/com_init.c @@ -17,9 +17,8 @@
#include <bootblock_common.h> #include <device/pnp_ops.h> -#include "onboard.h"
-#define SERIAL_DEV PNP_DEV(ITE8528_CMD_PORT, 1) /* ITE8528 UART1 */ +#define SERIAL_DEV PNP_DEV(0x6E, 1) /* ITE8528 UART1 */
void bootblock_mainboard_early_init(void) { diff --git a/src/mainboard/facebook/fbg1701/onboard.h b/src/mainboard/facebook/fbg1701/onboard.h index c22a63a..6e094ab 100644 --- a/src/mainboard/facebook/fbg1701/onboard.h +++ b/src/mainboard/facebook/fbg1701/onboard.h @@ -21,9 +21,6 @@ /* SD CARD gpio */ #define SDCARD_CD 81 /* Not used */
-#define ITE8528_CMD_PORT 0x6E -#define ITE8528_DATA_PORT 0x6F - /* Define the items to be measured or verified */ #define FSP (const char *)"fsp.bin" #define CMOS_LAYOUT (const char *)"cmos_layout.bin" diff --git a/src/mainboard/portwell/m107/com_init.c b/src/mainboard/portwell/m107/com_init.c index f19aba3..fc640dd 100644 --- a/src/mainboard/portwell/m107/com_init.c +++ b/src/mainboard/portwell/m107/com_init.c @@ -17,9 +17,8 @@
#include <bootblock_common.h> #include <device/pnp_ops.h> -#include "onboard.h"
-#define SERIAL_DEV PNP_DEV(ITE8528_CMD_PORT, 1) /* ITE8528 UART1 */ +#define SERIAL_DEV PNP_DEV(0x6E, 1) /* ITE8528 UART1 */
void bootblock_mainboard_early_init(void) { diff --git a/src/mainboard/portwell/m107/onboard.h b/src/mainboard/portwell/m107/onboard.h index fd4e4d6..3a5dee2 100644 --- a/src/mainboard/portwell/m107/onboard.h +++ b/src/mainboard/portwell/m107/onboard.h @@ -21,6 +21,4 @@ /* SD CARD gpio */ #define SDCARD_CD 81 /* Not used */
-#define ITE8528_CMD_PORT 0x6E -#define ITE8528_DATA_PORT 0x6F #endif
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37609 )
Change subject: mb/{facebook/portwell}: Remove ITE8258_CMD_PORT ......................................................................
Patch Set 1: Code-Review+1
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37609 )
Change subject: mb/{facebook/portwell}: Remove ITE8258_CMD_PORT ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37609 )
Change subject: mb/{facebook/portwell}: Remove ITE8258_CMD_PORT ......................................................................
mb/{facebook/portwell}: Remove ITE8258_CMD_PORT
ITE8258_CMD_PORT is used in com_init.c only. Replace ITE8258_CMD_PORT by fixed value in the c file. ITE8258_DATA_PORT is removed as this isn't used.
BUG=N/A TEST=build
Change-Id: I401da3f127db9e65763fd8d115eb274fbadbefbe Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37609 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/com_init.c M src/mainboard/facebook/fbg1701/onboard.h M src/mainboard/portwell/m107/com_init.c M src/mainboard/portwell/m107/onboard.h 4 files changed, 2 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Wim Vervoorn: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/com_init.c b/src/mainboard/facebook/fbg1701/com_init.c index f19aba3..fc640dd 100644 --- a/src/mainboard/facebook/fbg1701/com_init.c +++ b/src/mainboard/facebook/fbg1701/com_init.c @@ -17,9 +17,8 @@
#include <bootblock_common.h> #include <device/pnp_ops.h> -#include "onboard.h"
-#define SERIAL_DEV PNP_DEV(ITE8528_CMD_PORT, 1) /* ITE8528 UART1 */ +#define SERIAL_DEV PNP_DEV(0x6E, 1) /* ITE8528 UART1 */
void bootblock_mainboard_early_init(void) { diff --git a/src/mainboard/facebook/fbg1701/onboard.h b/src/mainboard/facebook/fbg1701/onboard.h index c22a63a..6e094ab 100644 --- a/src/mainboard/facebook/fbg1701/onboard.h +++ b/src/mainboard/facebook/fbg1701/onboard.h @@ -21,9 +21,6 @@ /* SD CARD gpio */ #define SDCARD_CD 81 /* Not used */
-#define ITE8528_CMD_PORT 0x6E -#define ITE8528_DATA_PORT 0x6F - /* Define the items to be measured or verified */ #define FSP (const char *)"fsp.bin" #define CMOS_LAYOUT (const char *)"cmos_layout.bin" diff --git a/src/mainboard/portwell/m107/com_init.c b/src/mainboard/portwell/m107/com_init.c index f19aba3..fc640dd 100644 --- a/src/mainboard/portwell/m107/com_init.c +++ b/src/mainboard/portwell/m107/com_init.c @@ -17,9 +17,8 @@
#include <bootblock_common.h> #include <device/pnp_ops.h> -#include "onboard.h"
-#define SERIAL_DEV PNP_DEV(ITE8528_CMD_PORT, 1) /* ITE8528 UART1 */ +#define SERIAL_DEV PNP_DEV(0x6E, 1) /* ITE8528 UART1 */
void bootblock_mainboard_early_init(void) { diff --git a/src/mainboard/portwell/m107/onboard.h b/src/mainboard/portwell/m107/onboard.h index fd4e4d6..3a5dee2 100644 --- a/src/mainboard/portwell/m107/onboard.h +++ b/src/mainboard/portwell/m107/onboard.h @@ -21,6 +21,4 @@ /* SD CARD gpio */ #define SDCARD_CD 81 /* Not used */
-#define ITE8528_CMD_PORT 0x6E -#define ITE8528_DATA_PORT 0x6F #endif
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)