Attention is currently required from: Paul Menzel. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56339 )
Change subject: asrock/e3c246d4i: Add board ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56339/comment/960bfc34_5fd4ecd6 PS2, Line 7: asrock/e3c246d4i: Add board
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/56339/comment/acf6f43c_8dbe7fa4 PS2, Line 9: Openbmc
OpenBMC
Done
https://review.coreboot.org/c/coreboot/+/56339/comment/511ada78_c61755f3 PS2, Line 11:
It’d be great if you could document if you wrote this from scratch or used some other board as templ […]
Done
https://review.coreboot.org/c/coreboot/+/56339/comment/d8dde708_40a41f6d PS2, Line 21: options
Option ROM?
Done
File src/mainboard/asrock/e3c246d4i/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56339/comment/288da789_f4e27a53 PS2, Line 47: device pci 12.0 on end # Thermal Subsystem
Should the comments be aligned?
Done
File src/mainboard/asrock/e3c246d4i/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/56339/comment/106f194a_28e65138 PS2, Line 27:
Please remove the blank line.
Done
-
Arthur Heymans (Code Review)