Attention is currently required from: Raymond Chung, Tim Wawrzynczak, Zhuohao Lee.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68806 )
Change subject: mb/google/brya/gaelin: Change DDR4 from interleave to non-interleave
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68806/comment/fee6d1d8_d2124cc1
PS3, Line 14: brask
firmware-brya-14505.B
https://review.coreboot.org/c/coreboot/+/68806/comment/07900394_21450c47
PS3, Line 15: emerge-brask coreboot
Build and pass MRC memory training
File src/mainboard/google/brya/variants/gaelin/memory.c:
https://review.coreboot.org/c/coreboot/+/68806/comment/d8e46672_489d8599
PS3, Line 33: bool variant_is_half_populated(void)
: {
: return false;
: }
:
The function is not needed. It is in baseboard/brask/memory.c already, you are doing the same here so you don't need to override it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68806
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34413343e3f7c283f49fbbdd277d9da39c09f9f8
Gerrit-Change-Number: 68806
Gerrit-PatchSet: 3
Gerrit-Owner: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eddy Lu
eddylu@ami.corp-partner.google.com
Gerrit-Attention: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 25 Oct 2022 03:35:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment