Attention is currently required from: Dinesh Gehlot, Edward Doan, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, YH Lin.
SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/83346?usp=email )
Change subject: mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
If gpio config is not correct, touchpad would never work. […]
Acknowledged
File src/mainboard/google/brya/variants/xol/gpio.c:
https://review.coreboot.org/c/coreboot/+/83346/comment/62b8d3f9_19c8f2b0?usp... :
PS1, Line 123: PAD_CFG_GPI_INT_LOCK(GPP_F14, NONE, LEVEL, LOCK_CONFIG),
Actually this was the original config in baseboard/brya/gpio.c […]
Acknowledged
File src/mainboard/google/brya/variants/xol/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83346/comment/b2cd8c5e_d88812e8?usp... :
PS1, Line 347: register "generic.detect" = "1"
We had the issue with this original config.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83346?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie1b59355a694e5a42367a20e03f6c5f93225e79c
Gerrit-Change-Number: 83346
Gerrit-PatchSet: 1
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Edward Doan
edoan@chromium.org
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward Doan
edoan@chromium.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Thu, 04 Jul 2024 04:36:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com