Change in coreboot[master]: mb/google/brya/var/vell: update gpio override - coreboot-gerrit

29 Nov 2021


      Attention is currently required from: Kevin Chiu, Paul Menzel, Nick Vaccaro, Wisley Chen, Shon Wang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 )
Change subject: mb/google/brya/var/vell: update gpio override
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/google/brya/variants/vell/gpio.c:
https://review.coreboot.org/c/coreboot/+/59305/comment/d093293f_8190766b 
PS8, Line 17: /* B2  : VRALERT# ==> RGB_RST_ODL */
            : 	PAD_CFG_GPI(GPP_B2, NONE, DEEP),
...
This for RGB keyboard to reset
then should it be an output, to control the state?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59305
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0
Gerrit-Change-Number: 59305
Gerrit-PatchSet: 12
Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-Attention: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Nov 2021 19:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-MessageType: comment