Attention is currently required from: Jason Nien, Martin Roth.
Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74595 )
Change subject: mb/google/skyrim: Update GPIO names ......................................................................
mb/google/skyrim: Update GPIO names
Update GPIO names in devicetree files to use the more descriptive versions in variant/gpio.h. This provides more clarity and insight into what GPIOs actually mean on the design.
BUG=b:278968729 TEST=builds
Signed-off-by: Jon Murphy jpmurphy@google.com Change-Id: I7443d1d1e3a2c00f2d2f76431f230a86faf551c6 --- M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb M src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb M src/mainboard/google/skyrim/variants/frostflow/overridetree.cb M src/mainboard/google/skyrim/variants/markarth/overridetree.cb M src/mainboard/google/skyrim/variants/skyrim/overridetree.cb M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 6 files changed, 70 insertions(+), 53 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/74595/1
diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb index f863197..29c92f6 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb @@ -174,7 +174,7 @@ register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "has_power_resource" = "true" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_10)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(BT_DISABLE)" register "enable_delay_ms" = "500" register "enable_off_delay_ms" = "200" register "use_gpio_for_status" = "true" @@ -193,7 +193,7 @@ chip drivers/i2c/tpm register "hid" = ""GOOG0005"" register "desc" = ""Ti50 TPM"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_18)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GSC_SOC_INT_L)" device i2c 50 alias ti50 on end end end diff --git a/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb b/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb index 23d7f40..e746405d 100644 --- a/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb @@ -91,8 +91,8 @@ chip drivers/i2c/hid register "generic.hid" = ""PIXA2635"" register "generic.desc" = ""PIXA Touchpad"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_40)" - #register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_40)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(SOC_TCHPAD_INT_ODL)" + #register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(SOC_TCHPAD_INT_ODL)" register "generic.wake" = "GEVENT_20" register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x01" @@ -105,7 +105,7 @@ register "hid" = ""RTL5682"" register "name" = ""RT58"" register "desc" = ""Realtek RT5682"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPIO_90)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(HP_INT_ODL)" register "property_count" = "1" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" diff --git a/src/mainboard/google/skyrim/variants/frostflow/overridetree.cb b/src/mainboard/google/skyrim/variants/frostflow/overridetree.cb index c10e0dd..19861dd 100644 --- a/src/mainboard/google/skyrim/variants/frostflow/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/frostflow/overridetree.cb @@ -62,7 +62,7 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_40)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(SOC_TCHPAD_INT_ODL)" register "wake" = "GEVENT_20" register "detect" = "1" device i2c 15 on end @@ -72,14 +72,14 @@ chip drivers/i2c/hid register "generic.hid" = ""ELAN9008"" register "generic.desc" = ""ELAN Touchscreen"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_29)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(TCHSCR_INT_ODL)" register "generic.detect" = "1" - register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PP3300_TCHSCR)" register "generic.enable_delay_ms" = "1" - register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_RST_L)" register "generic.reset_off_delay_ms" = "2" register "generic.reset_delay_ms" = "20" - register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_76)" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_REPORT_EN)" register "generic.stop_delay_ms" = "150" register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" @@ -88,7 +88,7 @@ end chip drivers/generic/gpio_keys register "name" = ""PENH"" - register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPIO_3)" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(SOC_PEN_DETECT_ODL)" register "key.dev_name" = ""EJCT"" register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" register "key.linux_code" = "SW_PEN_INSERTED" @@ -106,7 +106,7 @@ register "hid" = ""RTL5682"" register "name" = ""RT58"" register "desc" = ""Realtek RT5682"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPIO_90)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(HP_INT_ODL)" register "property_count" = "1" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" @@ -134,12 +134,12 @@ register "desc" = ""Fingerprint Reader"" register "hid" = "ACPI_DT_NAMESPACE_HID" register "compat_string" = ""google,cros-ec-uart"" - register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_24)" + register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(SOC_FP_INT_L)" register "wake" = "GEVENT_15" register "uart" = "ACPI_UART_RAW_DEVICE(3000000, 64)" register "has_power_resource" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_12)" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_4)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(SOC_FP_RST_L)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PWR_FP)" register "enable_delay_ms" = "3" device generic 0 alias fpmcu on probe FP FP_PRESENT diff --git a/src/mainboard/google/skyrim/variants/markarth/overridetree.cb b/src/mainboard/google/skyrim/variants/markarth/overridetree.cb index 3939d65..46a7a45 100644 --- a/src/mainboard/google/skyrim/variants/markarth/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/markarth/overridetree.cb @@ -68,7 +68,7 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_40)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(SOC_TCHPAD_INT_ODL)" register "wake" = "GEVENT_20" register "detect" = "1" device i2c 15 on end @@ -77,7 +77,7 @@ register "generic.hid" = ""SYNA0000"" register "generic.cid" = ""ACPI0C50"" register "generic.desc" = ""Synaptics Touchpad"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_40)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(SOC_TCHPAD_INT_ODL)" register "generic.wake" = "GEVENT_20" register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" @@ -88,14 +88,14 @@ chip drivers/i2c/hid register "generic.hid" = ""ELAN9004"" register "generic.desc" = ""ELAN Touchscreen"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_29)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(TCHSCR_INT_ODL)" register "generic.detect" = "1" - register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PP3300_TCHSCR)" register "generic.enable_delay_ms" = "10" - register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_RST_L)" register "generic.reset_off_delay_ms" = "1" register "generic.reset_delay_ms" = "10" - register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_76)" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_REPORT_EN)" register "generic.stop_delay_ms" = "150" register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" @@ -108,7 +108,7 @@ register "hid" = ""RTL5682"" register "name" = ""RT58"" register "desc" = ""Realtek RT5682"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPIO_90)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(HP_INT_ODL)" register "property_count" = "1" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" diff --git a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb index eb16120..0f66fe2 100644 --- a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb @@ -63,9 +63,9 @@ register "type" = "UPC_TYPE_INTERNAL" register "group" = "ACPI_PLD_GROUP(2, 2)" register "has_power_resource" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_42)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(WWAN_RST)" register "reset_off_delay_ms" = "20" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_8)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PWR_WWAN_X)" register "enable_delay_ms" = "20" device usb 3.1 on end end @@ -121,7 +121,7 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_40)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(SOC_TCHPAD_INT_ODL)" register "wake" = "GEVENT_20" register "detect" = "1" device i2c 15 on end @@ -131,14 +131,14 @@ chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_29)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(TCHSCR_INT_ODL)" register "generic.detect" = "1" - register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PP3300_TCHSCR)" register "generic.enable_delay_ms" = "10" - register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_RST_L)" register "generic.reset_off_delay_ms" = "1" register "generic.reset_delay_ms" = "10" - register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_76)" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_REPORT_EN)" register "generic.stop_delay_ms" = "180" register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" @@ -149,13 +149,13 @@ register "hid" = ""ELAN0001"" register "desc" = ""ELAN Touchscreen"" register "detect" = "1" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_29)" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(TCHSCR_INT_ODL)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PP3300_TCHSCR)" register "enable_delay_ms" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_RST_L)" register "reset_delay_ms" = "20" register "reset_off_delay_ms" = "2" - register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_76)" + register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_REPORT_EN)" register "stop_off_delay_ms" = "2" register "has_power_resource" = "1" device i2c 10 on end @@ -166,7 +166,7 @@ register "hid" = ""RTL5682"" register "name" = ""RT58"" register "desc" = ""Realtek RT5682"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPIO_90)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(HP_INT_ODL)" register "property_count" = "1" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" @@ -176,7 +176,7 @@ end end chip drivers/i2c/nau8825 - register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_90)" + register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(HP_INT_ODL)" register "jkdet_enable" = "1" register "jkdet_pull_enable" = "0" register "jkdet_polarity" = "1" # ActiveLow @@ -218,7 +218,7 @@ end # I2C2 chip drivers/generic/max98357a register "hid" = ""MX98360A"" - register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_139)" + register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_SPKR)" register "sdmode_delay" = "5" device generic 0.1 on probe AUDIO_DB AUDIO_DB_C_NAU88L25YGB_A_MAX98360AENL @@ -231,12 +231,12 @@ register "desc" = ""Fingerprint Reader"" register "hid" = "ACPI_DT_NAMESPACE_HID" register "compat_string" = ""google,cros-ec-uart"" - register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_24)" + register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(SOC_FP_INT_L)" register "wake" = "GEVENT_15" register "uart" = "ACPI_UART_RAW_DEVICE(3000000, 64)" register "has_power_resource" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_12)" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_4)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(SOC_FP_RST_L)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PWR_FP)" register "enable_delay_ms" = "3" device generic 0 alias fpmcu on probe FP FP_PRESENT diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb index 4297f90..f541f62 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb @@ -166,7 +166,7 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_40)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(SOC_TCHPAD_INT_ODL)" register "wake" = "GEVENT_20" register "detect" = "1" device i2c 15 on end @@ -174,7 +174,7 @@ chip drivers/i2c/hid register "generic.hid" = ""GXTP7863"" register "generic.desc" = ""Goodix Touchpad"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_40)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(SOC_TCHPAD_INT_ODL)" register "generic.wake" = "GEVENT_20" register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" @@ -185,14 +185,14 @@ chip drivers/i2c/hid register "generic.hid" = ""ELAN900C"" register "generic.desc" = ""ELAN Touchscreen"" - register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_29)" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(TCHSCR_INT_ODL)" register "generic.detect" = "1" - register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PP3300_TCHSCR)" register "generic.enable_delay_ms" = "10" - register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_RST_L)" register "generic.reset_off_delay_ms" = "1" register "generic.reset_delay_ms" = "10" - register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_76)" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_REPORT_EN)" register "generic.stop_delay_ms" = "150" register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" @@ -203,13 +203,13 @@ register "hid" = ""MLFS0000"" register "desc" = ""Melfas Touchscreen"" register "detect" = "1" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_29)" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_131)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(TCHSCR_INT_ODL)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PP3300_TCHSCR)" register "enable_delay_ms" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_136)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_RST_L)" register "reset_delay_ms" = "20" register "reset_off_delay_ms" = "2" - register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_76)" + register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(TCHSCR_REPORT_EN)" register "stop_off_delay_ms" = "2" register "has_power_resource" = "1" device i2c 34 on end @@ -220,7 +220,7 @@ register "hid" = ""RTL5682"" register "name" = ""RT58"" register "desc" = ""Realtek RT5682"" - register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPIO_90)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(HP_INT_ODL)" register "property_count" = "1" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" @@ -248,12 +248,12 @@ register "desc" = ""Fingerprint Reader"" register "hid" = "ACPI_DT_NAMESPACE_HID" register "compat_string" = ""google,cros-ec-uart"" - register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_24)" + register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(SOC_FP_INT_L)" register "wake" = "GEVENT_15" register "uart" = "ACPI_UART_RAW_DEVICE(3000000, 64)" register "has_power_resource" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_12)" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_4)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(SOC_FP_RST_L)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(EN_PWR_FP)" register "enable_delay_ms" = "3" device generic 0 alias fpmcu on probe FP FP_PRESENT
-
Jon Murphy (Code Review)