Change in coreboot[master]: src: Remove whitespace between 'sizeof' and '('

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43720 )

Change subject: src: Remove whitespace between 'sizeof' and '('
......................................................................

src: Remove whitespace between 'sizeof' and '('

Change-Id: Iaf22dc1986427e8aa4521b0e9b40fafa5a29dbbd
Signed-off-by: Elyes HAOUAS 
---
M src/device/oprom/x86emu/debug.c
M src/drivers/i2c/at24rf08c/lenovo_serials.c
M src/drivers/intel/fsp2_0/hand_off_block.c
M src/drivers/intel/gma/vbt.c
M src/drivers/usb/ehci_debug.c
M src/ec/lenovo/h8/h8.c
M src/soc/intel/baytrail/southcluster.c
7 files changed, 26 insertions(+), 26 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/43720/1

diff --git a/src/device/oprom/x86emu/debug.c b/src/device/oprom/x86emu/debug.c
index 9e216e9..ab55198 100644
--- a/src/device/oprom/x86emu/debug.c
+++ b/src/device/oprom/x86emu/debug.c
@@ -170,7 +170,7 @@
 void x86emu_decode_printf2 (const char *x, int y)
 {
     char temp[100];
-    snprintf(temp, sizeof (temp), x,y);
+    snprintf(temp, sizeof(temp), x,y);
     strcpy(M.x86.decoded_buf+M.x86.enc_str_pos,temp);
     M.x86.enc_str_pos += strlen(temp);
 }
diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c
index afadc6f..36e7ab2 100644
--- a/src/drivers/i2c/at24rf08c/lenovo_serials.c
+++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c
@@ -45,7 +45,7 @@
    	int t = at24rf08c_read_byte(dev, start + i);

if (t < 0x20 || t > 0x7f) {
-			memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+			memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
    		return;
    	}
    	result[i] = t;
@@ -60,7 +60,7 @@
    dev = at24rf08c_find_bank(bank);
    if (dev == NULL) {
    	printk(BIOS_WARNING, "EEPROM not found\n");
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
    	return;
    }

@@ -75,7 +75,7 @@
    if (already_read)
    	return result;

-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));
    at24rf08c_read_string(0, 0x2e, 7, result);

already_read = 1;
@@ -90,7 +90,7 @@
    if (already_read)
    	return result;

-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));
    at24rf08c_read_string(0, 0x27, 7, result);

already_read = 1;
@@ -119,7 +119,7 @@
    	return;
    }

-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));

dev = dev_find_slot_on_smbus(1, 0x56);
    if (dev == NULL) {
@@ -141,7 +141,7 @@
    			break;
    	}
    	if (t < 0) {
-			memset(result, 0, sizeof (result));
+			memset(result, 0, sizeof(result));
    		break;
    	}
    	result[remap[i]] = t;
@@ -162,17 +162,17 @@
    if (already_read)
    	return result;

-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));

dev = at24rf08c_find_bank(2);
    if (dev == NULL) {
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
    	return result;
    }

len = at24rf08c_read_byte(dev, 0x26) - 2;
    if (len < 0 || len > sizeof(result) - 1) {
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
    	return result;
    }

diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
index fdc92a7..44c91a2 100644
--- a/src/drivers/intel/fsp2_0/hand_off_block.c
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -218,7 +218,7 @@

fvi = (void *)&fvih[1];
    str_ptr = (char *)((uintptr_t)fvi +
-			 (fvih->Count * sizeof (FIRMWARE_VERSION_INFO)));
+			 (fvih->Count * sizeof(FIRMWARE_VERSION_INFO)));
    size -= sizeof(SMBIOS_STRUCTURE);

for (index = 0; index < fvih->Count; index++) {
diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c
index f1ad265..b42c52d 100644
--- a/src/drivers/intel/gma/vbt.c
+++ b/src/drivers/intel/gma/vbt.c
@@ -15,31 +15,31 @@
 {
    u8 *ptr;

-	memset(head, 0, sizeof (*head));
+	memset(head, 0, sizeof(*head));

-	memset(head->signature, ' ', sizeof (head->signature));
+	memset(head->signature, ' ', sizeof(head->signature));
    memcpy(head->signature, idstr,
-		MIN(strlen(idstr), sizeof (head->signature)));
+		MIN(strlen(idstr), sizeof(head->signature)));
    head->version = 100;
-	head->header_size = sizeof (*head);
-	head->bdb_offset = sizeof (*head);
+	head->header_size = sizeof(*head);
+	head->bdb_offset = sizeof(*head);

struct bdb_header *const bdb_head = (struct bdb_header *)(head + 1);
-	memset(bdb_head, 0, sizeof (*bdb_head));
+	memset(bdb_head, 0, sizeof(*bdb_head));
    memcpy(bdb_head->signature, "BIOS_DATA_BLOCK ", 16);
    bdb_head->version = 0xa8;
-	bdb_head->header_size = sizeof (*bdb_head);
+	bdb_head->header_size = sizeof(*bdb_head);

ptr = (u8 *)(bdb_head + 1);

ptr[0] = BDB_GENERAL_FEATURES;
-	ptr[1] = sizeof (struct bdb_general_features);
-	ptr[2] = sizeof (struct bdb_general_features) >> 8;
+	ptr[1] = sizeof(struct bdb_general_features);
+	ptr[2] = sizeof(struct bdb_general_features) >> 8;
    ptr += 3;

struct bdb_general_features *const genfeat =
    	(struct bdb_general_features *)ptr;
-	memset(genfeat, 0, sizeof (*genfeat));
+	memset(genfeat, 0, sizeof(*genfeat));
    genfeat->panel_fitting = 3;
    genfeat->flexaim = 1;
    genfeat->download_ext_vbt = 1;
@@ -50,7 +50,7 @@
    genfeat->int_crt_support = 1;
    genfeat->dp_ssc_enb = 1;

-	ptr += sizeof (*genfeat);
+	ptr += sizeof(*genfeat);

bdb_head->bdb_size = ptr - (u8 *)bdb_head;
    head->vbt_size = ptr - (u8 *)head;
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c
index 07d87ae..5998172 100644
--- a/src/drivers/usb/ehci_debug.c
+++ b/src/drivers/usb/ehci_debug.c
@@ -436,7 +436,7 @@
    int playtimes = 3;

/* Keep all endpoints disabled before any printk() call. */
-	memset(info, 0, sizeof (*info));
+	memset(info, 0, sizeof(*info));
    info->ehci_base = ehci_bar;
    info->ehci_debug = ehci_bar + offset;
    info->ep_pipe[0].status	|= DBGP_EP_NOT_PRESENT;
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index aa1877e..093a639 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -172,14 +172,14 @@
    for (i = 0; i < 8; i++) {
    	c = ec_read(0xf0 + i);
    	if (c < 0x20 || c > 0x7f) {
-			i = snprintf(str, sizeof (str), "*INVALID");
+			i = snprintf(str, sizeof(str), "*INVALID");
    		break;
    	}
    	str[i] = c;
    }

/* EC firmware function specification version */
-	i += snprintf(str + i, sizeof (str) - i, "-%u.%u", ec_read(0xef), ec_read(0xeb));
+	i += snprintf(str + i, sizeof(str) - i, "-%u.%u", ec_read(0xef), ec_read(0xeb));

i = MIN(buf_len, i);
    memcpy(buf, str, i);
diff --git a/src/soc/intel/baytrail/southcluster.c b/src/soc/intel/baytrail/southcluster.c
index a836d41..1a2869d 100644
--- a/src/soc/intel/baytrail/southcluster.c
+++ b/src/soc/intel/baytrail/southcluster.c
@@ -500,7 +500,7 @@

gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS);
    if (!gnvs) {
-		gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof (*gnvs));
+		gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(*gnvs));
    	if (gnvs)
    		memset(gnvs, 0, sizeof(*gnvs));
    }

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43720 )

Change subject: src: Remove whitespace between 'sizeof' and '('
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43720/1/src/device/oprom/x86emu/deb... 
File src/device/oprom/x86emu/debug.c:

https://review.coreboot.org/c/coreboot/+/43720/1/src/device/oprom/x86emu/deb... 
PS1, Line 173:     snprintf(temp, sizeof(temp), x,y);
please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/43720/1/src/device/oprom/x86emu/deb... 
PS1, Line 173:     snprintf(temp, sizeof(temp), x,y);
space required after that ',' (ctx:VxV)

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43720 )

Change subject: src: Remove whitespace between 'sizeof' and '('
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43720 )

Change subject: src: Remove whitespace between 'sizeof' and '('
......................................................................

src: Remove whitespace between 'sizeof' and '('

Change-Id: Iaf22dc1986427e8aa4521b0e9b40fafa5a29dbbd
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43720
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/device/oprom/x86emu/debug.c
M src/drivers/i2c/at24rf08c/lenovo_serials.c
M src/drivers/intel/fsp2_0/hand_off_block.c
M src/drivers/intel/gma/vbt.c
M src/drivers/usb/ehci_debug.c
M src/ec/lenovo/h8/h8.c
M src/soc/intel/baytrail/southcluster.c
7 files changed, 26 insertions(+), 26 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/device/oprom/x86emu/debug.c b/src/device/oprom/x86emu/debug.c
index 9e216e9..ab55198 100644
--- a/src/device/oprom/x86emu/debug.c
+++ b/src/device/oprom/x86emu/debug.c
@@ -170,7 +170,7 @@
 void x86emu_decode_printf2 (const char *x, int y)
 {
     char temp[100];
-    snprintf(temp, sizeof (temp), x,y);
+    snprintf(temp, sizeof(temp), x,y);
     strcpy(M.x86.decoded_buf+M.x86.enc_str_pos,temp);
     M.x86.enc_str_pos += strlen(temp);
 }
diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c
index afadc6f..36e7ab2 100644
--- a/src/drivers/i2c/at24rf08c/lenovo_serials.c
+++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c
@@ -45,7 +45,7 @@
    	int t = at24rf08c_read_byte(dev, start + i);

if (t < 0x20 || t > 0x7f) {
-			memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+			memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
    		return;
    	}
    	result[i] = t;
@@ -60,7 +60,7 @@
    dev = at24rf08c_find_bank(bank);
    if (dev == NULL) {
    	printk(BIOS_WARNING, "EEPROM not found\n");
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
    	return;
    }

@@ -75,7 +75,7 @@
    if (already_read)
    	return result;

-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));
    at24rf08c_read_string(0, 0x2e, 7, result);

already_read = 1;
@@ -90,7 +90,7 @@
    if (already_read)
    	return result;

-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));
    at24rf08c_read_string(0, 0x27, 7, result);

already_read = 1;
@@ -119,7 +119,7 @@
    	return;
    }

-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));

dev = dev_find_slot_on_smbus(1, 0x56);
    if (dev == NULL) {
@@ -141,7 +141,7 @@
    			break;
    	}
    	if (t < 0) {
-			memset(result, 0, sizeof (result));
+			memset(result, 0, sizeof(result));
    		break;
    	}
    	result[remap[i]] = t;
@@ -162,17 +162,17 @@
    if (already_read)
    	return result;

-	memset(result, 0, sizeof (result));
+	memset(result, 0, sizeof(result));

dev = at24rf08c_find_bank(2);
    if (dev == NULL) {
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
    	return result;
    }

len = at24rf08c_read_byte(dev, 0x26) - 2;
    if (len < 0 || len > sizeof(result) - 1) {
-		memcpy(result, ERROR_STRING, sizeof (ERROR_STRING));
+		memcpy(result, ERROR_STRING, sizeof(ERROR_STRING));
    	return result;
    }

diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
index fdc92a7..44c91a2 100644
--- a/src/drivers/intel/fsp2_0/hand_off_block.c
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -218,7 +218,7 @@

fvi = (void *)&fvih[1];
    str_ptr = (char *)((uintptr_t)fvi +
-			 (fvih->Count * sizeof (FIRMWARE_VERSION_INFO)));
+			 (fvih->Count * sizeof(FIRMWARE_VERSION_INFO)));
    size -= sizeof(SMBIOS_STRUCTURE);

for (index = 0; index < fvih->Count; index++) {
diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c
index f1ad265..b42c52d 100644
--- a/src/drivers/intel/gma/vbt.c
+++ b/src/drivers/intel/gma/vbt.c
@@ -15,31 +15,31 @@
 {
    u8 *ptr;

-	memset(head, 0, sizeof (*head));
+	memset(head, 0, sizeof(*head));

-	memset(head->signature, ' ', sizeof (head->signature));
+	memset(head->signature, ' ', sizeof(head->signature));
    memcpy(head->signature, idstr,
-		MIN(strlen(idstr), sizeof (head->signature)));
+		MIN(strlen(idstr), sizeof(head->signature)));
    head->version = 100;
-	head->header_size = sizeof (*head);
-	head->bdb_offset = sizeof (*head);
+	head->header_size = sizeof(*head);
+	head->bdb_offset = sizeof(*head);

struct bdb_header *const bdb_head = (struct bdb_header *)(head + 1);
-	memset(bdb_head, 0, sizeof (*bdb_head));
+	memset(bdb_head, 0, sizeof(*bdb_head));
    memcpy(bdb_head->signature, "BIOS_DATA_BLOCK ", 16);
    bdb_head->version = 0xa8;
-	bdb_head->header_size = sizeof (*bdb_head);
+	bdb_head->header_size = sizeof(*bdb_head);

ptr = (u8 *)(bdb_head + 1);

ptr[0] = BDB_GENERAL_FEATURES;
-	ptr[1] = sizeof (struct bdb_general_features);
-	ptr[2] = sizeof (struct bdb_general_features) >> 8;
+	ptr[1] = sizeof(struct bdb_general_features);
+	ptr[2] = sizeof(struct bdb_general_features) >> 8;
    ptr += 3;

struct bdb_general_features *const genfeat =
    	(struct bdb_general_features *)ptr;
-	memset(genfeat, 0, sizeof (*genfeat));
+	memset(genfeat, 0, sizeof(*genfeat));
    genfeat->panel_fitting = 3;
    genfeat->flexaim = 1;
    genfeat->download_ext_vbt = 1;
@@ -50,7 +50,7 @@
    genfeat->int_crt_support = 1;
    genfeat->dp_ssc_enb = 1;

-	ptr += sizeof (*genfeat);
+	ptr += sizeof(*genfeat);

bdb_head->bdb_size = ptr - (u8 *)bdb_head;
    head->vbt_size = ptr - (u8 *)head;
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c
index 07d87ae..5998172 100644
--- a/src/drivers/usb/ehci_debug.c
+++ b/src/drivers/usb/ehci_debug.c
@@ -436,7 +436,7 @@
    int playtimes = 3;

/* Keep all endpoints disabled before any printk() call. */
-	memset(info, 0, sizeof (*info));
+	memset(info, 0, sizeof(*info));
    info->ehci_base = ehci_bar;
    info->ehci_debug = ehci_bar + offset;
    info->ep_pipe[0].status	|= DBGP_EP_NOT_PRESENT;
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index aa1877e..093a639 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -172,14 +172,14 @@
    for (i = 0; i < 8; i++) {
    	c = ec_read(0xf0 + i);
    	if (c < 0x20 || c > 0x7f) {
-			i = snprintf(str, sizeof (str), "*INVALID");
+			i = snprintf(str, sizeof(str), "*INVALID");
    		break;
    	}
    	str[i] = c;
    }

/* EC firmware function specification version */
-	i += snprintf(str + i, sizeof (str) - i, "-%u.%u", ec_read(0xef), ec_read(0xeb));
+	i += snprintf(str + i, sizeof(str) - i, "-%u.%u", ec_read(0xef), ec_read(0xeb));

i = MIN(buf_len, i);
    memcpy(buf, str, i);
diff --git a/src/soc/intel/baytrail/southcluster.c b/src/soc/intel/baytrail/southcluster.c
index 45c588a..882c43d 100644
--- a/src/soc/intel/baytrail/southcluster.c
+++ b/src/soc/intel/baytrail/southcluster.c
@@ -490,7 +490,7 @@

gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS);
    if (!gnvs) {
-		gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof (*gnvs));
+		gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(*gnvs));
    	if (gnvs)
    		memset(gnvs, 0, sizeof(*gnvs));
    }