Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85751?usp=email )
Change subject: soc/mediatek/mt8196: Set SPMI-P SCL/SDA SoC PD ......................................................................
Patch Set 1:
(2 comments)
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/85751/comment/24aef166_cf8cd70a?usp... : PS1, Line 178: setbits32p(SPMI_SCL_P_PD_ADDR, : BIT(SPMI_SCL_P_PD_OFFSET) | BIT(SPMI_SDA_P_PD_OFFSET)); This is identical to ``` gpio_set_pull(GPIO(SPMI_P_SCL), GPIO_PULL_ENABLE, GPIO_PULL_DOWN); gpio_set_pull(GPIO(SPMI_P_SCA), GPIO_PULL_ENABLE, GPIO_PULL_DOWN); ```
https://review.coreboot.org/c/coreboot/+/85751/comment/e9c3e825_69d4e489?usp... : PS1, Line 177: if (dev->slvid == SPMI_SLAVE_6) { : setbits32p(SPMI_SCL_P_PD_ADDR, : BIT(SPMI_SCL_P_PD_OFFSET) | BIT(SPMI_SDA_P_PD_OFFSET)); : printk(BIOS_INFO, "%s, Set SoC PD for SPMI-P SCL/SDA, [0x%x] = 0x%x\n", : __func__, SPMI_SCL_P_PD_ADDR, read32p(SPMI_SCL_P_PD_ADDR)); : } This setting also effects other slaves, right ? Should we revert the setting for other slaves ? Please elaborate in a comment or the commit message.