[S] Change in coreboot[master]: util/ifdtool/ifdtool.c: Fix default FMAP generation - coreboot-gerrit

25 Apr 2023


      Attention is currently required from: Stefan Reinauer, Arthur Heymans.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74735 )
Change subject: util/ifdtool/ifdtool.c: Fix default FMAP generation
......................................................................
Patch Set 4:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/74735/comment/a76b0c38_856e3e53 
PS3, Line 460: /* is region invalid? */
             : 		if (region.size < 1)
             : 			continue;
...
...
What about this one? […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I790d7f5631ecef3043b2c17c41430dc4fd854f72
Gerrit-Change-Number: 74735
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 25 Apr 2023 18:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune maximilian.brune@9elements.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment