EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40415 )
Change subject: mb/google/puff: add a region to cache SPD data
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40415/5/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/romstage_spd_smbus.c:
https://review.coreboot.org/c/coreboot/+/40415/5/src/mainboard/google/hatch/...
PS5, Line 47: if (need_update_cache)
how about this? […]
Thinking of this, dimm_changed default true then
1. if you don't touch dimm_changed = check_if_dimm_changed(spd_cache, &blk); you need update
2. if you touch dimm_changed = check_if_dimm_changed(spd_cache, &blk); And still true,you need update. If false, you can't reach the else statement.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40415
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d07fddf113a767d62394cb31e33b56f22f74351
Gerrit-Change-Number: 40415
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 May 2020 04:24:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane.chen@intel.com
Gerrit-MessageType: comment