Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74314 )
Change subject: soc/amd: Clarify ACPI _PRT entry generation
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/pci/acpi_prt.c:
https://review.coreboot.org/c/coreboot/+/74314/comment/a4dc043f_f7dd6fcf
PS2, Line 10: /* GNB IO-APIC is located after the FCH IO-APIC */
Ack
i'm ok with revisiting this later. also not sure if Arthur might have some patches for this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74314
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d862e37424f9fea7f269cd09e9e90056531b643
Gerrit-Change-Number: 74314
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Fri, 14 Apr 2023 13:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment